[GitHub] [incubator-nuttx] johannes-nivus commented on pull request #1499: FAT Filesystem: UTF8 support for long filenames, bugfixes.

[GitBox <gi...@apache.org>]

johannes-nivus commented on pull request #1499:
URL: https://github.com/apache/incubator-nuttx/pull/1499#issuecomment-667534104


   @xiaoxiang781216 
   For sure I thought about your proposed changes earlier, but this would force activating CONFIG_LIBC_WCHAR for a non exposed interface.
   The usage of wide characters, in the case of the PR, is limited to only one file (fs_fat32dirent.c) and is not visible to the user.
   
   Also I didn't want to override the multibyte to wchar (and vice versa) functions because this affects more aspects than only FAT filesystem, I didn't want to force users to use UTF8 all over the OS.
   A clean approach would be adding locales with codepages or UTF8, which then control the behaviour multibyte to wchar functions.
   
   As soon as there is locale support (for UTF8 as well as single byte codepages) I would be happy to fix and clean my current approach, but if there's consensus to use wchar lib and rewrite/add the multibyte to wchar functions already now, I'll do it as well.
   
   Regards, Johannes
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org