[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5490: risc-v: Let g_cpu_basestack determined at compile time

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on a change in pull request #5490:
URL: https://github.com/apache/incubator-nuttx/pull/5490#discussion_r805840965



##########
File path: arch/risc-v/src/common/riscv_cpuidlestack.c
##########
@@ -83,7 +83,7 @@ static uint8_t aligned_data(16) cpu7_idlestack[CONFIG_IDLETHREAD_STACKSIZE];
  * Public Data
  ****************************************************************************/
 
-uint8_t *g_cpu_basestack[CONFIG_SMP_NCPUS] =
+uint8_t * const g_cpu_basestack[CONFIG_SMP_NCPUS] =

Review comment:
       change to const uint8_t *

##########
File path: arch/risc-v/src/common/riscv_internal.h
##########
@@ -117,7 +117,7 @@ EXTERN uintptr_t g_idle_topstack;
 
 /* Address of per-cpu idle stack base */
 
-EXTERN uint8_t *g_cpu_basestack[CONFIG_SMP_NCPUS];
+EXTERN uint8_t * const g_cpu_basestack[CONFIG_SMP_NCPUS];

Review comment:
       ditto

##########
File path: arch/risc-v/src/k210/k210_head.S
##########
@@ -55,7 +55,7 @@ __start:
 
   /* In case of single CPU config, stop here */
 
-#if CONFIG_SMP_NCPUS == 1
+#if !(defined CONFIG_SMP) || (CONFIG_SMP_NCPUS == 1)

Review comment:
       move to previous patch instead




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org