You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/02 04:41:44 UTC

[GitHub] [cloudstack] sureshanaparti opened a new pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

sureshanaparti opened a new pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122


   Description
   -------------
   <!--- Describe your changes in detail -->
   Fix to pick the max data volumes limit using the actual hypervisor version, instead of "default" version
   
   Changes:
   - Use the hypervisor version in the host table when product_version parameter in host details doesn't exist or is empty
   
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   Fixes: #4101 
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   - Create VM and attach disk, verified the max data disks limit is picked from hypervisor version
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643059963


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643686185


   @blueorangutan test
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643060393


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643530179


   @blueorangutan test
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-642613279


   Packaging result: ✔centos7 ✔debian. JID-1348


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643686231


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643530264


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-643755120


   <b>Trillian test result (tid-1720)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 45686 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4122-t1720-kvm-centos7.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 82 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 319.92 | test_vpc_redundant.py
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-642596218


   @sureshanaparti apparently not :(
   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd merged pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] rhtyd commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-640319975


   @sureshanaparti can you kick packaging and tests yourself?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cloudstack] blueorangutan commented on pull request #4122: Maximum data volumes limit is picked from "default" version of hypervisor, instead of actual hypervisor version

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4122:
URL: https://github.com/apache/cloudstack/pull/4122#issuecomment-642596768


   @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org