You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/02 09:23:41 UTC

[GitHub] [flink] liuyongvs opened a new pull request #12804: [FLINK-17425][blink plannger] Dynamic Source supportsLimit pushdown

liuyongvs opened a new pull request #12804:
URL: https://github.com/apache/flink/pull/12804


   ## What is the purpose of the change
   
   *make DynamicTableSource support limit Pushdown*
   
   
   ## Brief change log
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: ( no )
     - The runtime per-record code paths (performance sensitive): ( no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: ( no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes )
     - If yes, how is the feature documented? (JavaDocs)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on pull request #12804: [FLINK-17426][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-653376237


   Hi @liuyongvs , we can't merge PR if there is no test coverage, because we don't know whether it works or not. I don't know why we don't have a unit test class for the legacy one, but it maybe tested in other classes. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuyongvs commented on pull request #12804: [FLINK-17426][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-653464142


   @wuchong thanks. I will add it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuyongvs closed pull request #12804: [FLINK-17426][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
liuyongvs closed pull request #12804:
URL: https://github.com/apache/flink/pull/12804


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuyongvs commented on pull request #12804: [FLINK-17426][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-653286801


   i have already modified the PR description of JIRA ID


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on pull request #12804: [FLINK-17425][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-652908219


   Btw, I think you may tag the wrong JIRA ID. FLINK-17425 is for filter push down. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] liuyongvs commented on pull request #12804: [FLINK-17425][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
liuyongvs commented on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-653286188


   @wuchong ，yeap, i tag the wrong JIRA ID. Do I need commit a new PR?
   The LimitPushDown LegacyTableSource i don't find unit test, so i also don't add unit test.
   Because limit pushdown is diffirent fron filter/project/partition pushdown at TableScan. limitPushDown should be FlinkLogicalTableSourceScan while others are LogicalTableScan.  FlinkLogicalTableSourceScanConverter converts the 
   LogicalTableScan to FlinkLogicalTableSourceScan 
   Ant I don't know why LimitPushDown this design .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12804: [FLINK-17425][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-652902630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8a4fa6491481c3c34881855c40e048fcab6fb857",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4164",
       "triggerID" : "8a4fa6491481c3c34881855c40e048fcab6fb857",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8a4fa6491481c3c34881855c40e048fcab6fb857 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4164) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] wuchong commented on pull request #12804: [FLINK-17425][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-652907916


   Could you add some tests? You can take `PushFilterIntoLegacyTableSourceScanRuleTest` as an example. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12804: [FLINK-17425][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-652897036


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 8a4fa6491481c3c34881855c40e048fcab6fb857 (Thu Jul 02 09:26:47 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12804: [FLINK-17425][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-652902630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8a4fa6491481c3c34881855c40e048fcab6fb857",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4164",
       "triggerID" : "8a4fa6491481c3c34881855c40e048fcab6fb857",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8a4fa6491481c3c34881855c40e048fcab6fb857 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4164) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12804: [FLINK-17425][blink plannger] Dynamic Source supportsLimit pushdown

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12804:
URL: https://github.com/apache/flink/pull/12804#issuecomment-652902630


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "8a4fa6491481c3c34881855c40e048fcab6fb857",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "8a4fa6491481c3c34881855c40e048fcab6fb857",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 8a4fa6491481c3c34881855c40e048fcab6fb857 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org