You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by guoxiaolongzte <gi...@git.apache.org> on 2018/01/10 08:19:36 UTC

[GitHub] spark pull request #20216: [SPARK-23024][WEB-UI]Spark ui about the contents ...

GitHub user guoxiaolongzte opened a pull request:

    https://github.com/apache/spark/pull/20216

    [SPARK-23024][WEB-UI]Spark ui about the contents of the form need to have hidden and show features, when the table records very much.

    ## What changes were proposed in this pull request?
    Spark ui about the contents of the form need to have hidden and show features, when the table records very much. Because sometimes you do not care about the record of the table, you just want to see the contents of the next table, but you have to scroll the scroll bar for a long time to see the contents of the next table.
    
    Currently we have about 500 workers, but I just wanted to see the logs for the running applications table. I had to scroll through the scroll bars for a long time to see the logs for the running applications table.
    
    In order to ensure functional consistency, I modified the Master Page, Worker Page, Job Page, Stage Page, Task Page, Configuration Page, Storage Page, Pool Page.
    
    ## How was this patch tested?
    manual tests
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/guoxiaolongzte/spark SPARK-23024

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20216
    
----
commit 1e4a18616a41dfbb4d6e58134facd5e593846af5
Author: guoxiaolong <gu...@...>
Date:   2018-01-10T08:16:40Z

    [SPARK-23024][WEB-UI]Spark ui about the contents of the form need to have hidden and show features, when the table records very much.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by ajbozarth <gi...@git.apache.org>.

Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    LGTM now


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    Dear Sir, However, the real spark big data environment, a very large number of workers, every day running a very large number of applications, has completed a very large number of applications, there are also some failed applications. 
    When so much data are loaded into the WEB UI, coupled with slow Internet access and other factors, if you have a hidden form of the function, not only for the overall look and feel of the WEB UI neat, more personal feel more convenient than jump access.
    If you jump to a table and view the table's records, if you want to see the records in other tables, you have to flip it up and down because the jump's link is at the top of the page.
    Attachment has been uploaded.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    This basically just makes the Workers / Apps lists collapsible in the same way as other blocks? that sounds fine.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    No, just hide the table, in fact, the data is already on the page, but we can not see.
    When we refresh the page, it will re-show all the data.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by srowen <gi...@git.apache.org>.

Github user srowen commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    But @guoxiaolongzte your change doesn't cause it to load less data, right?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    **[Test build #4056 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4056/testReport)** for PR 20216 at commit [`4b6cdbb`](https://github.com/apache/spark/commit/4b6cdbb23d308f0418468cfd3740e4058926570e).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by guoxiaolongzte <gi...@git.apache.org>.

Github user guoxiaolongzte commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    1. The first suggestion, I will fix it.
    2. The second suggestion, I think it is not necessary. Because spark system is small, such as 3 workers, do not need to hide the table from the beginning.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    **[Test build #4056 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4056/testReport)** for PR 20216 at commit [`4b6cdbb`](https://github.com/apache/spark/commit/4b6cdbb23d308f0418468cfd3740e4058926570e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    Can one of the admins verify this patch?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by ajbozarth <gi...@git.apache.org>.

Github user ajbozarth commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    Thanks for updating the first one, but I stand by the second. The UI should be consistent and in the previous use of this feature it persisted so it should here, even if it's not necessary every time.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20216: [SPARK-23024][WEB-UI]Spark ui about the contents of the ...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20216
  
    **[Test build #4055 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/4055/testReport)** for PR 20216 at commit [`4b6cdbb`](https://github.com/apache/spark/commit/4b6cdbb23d308f0418468cfd3740e4058926570e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org