You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Rick Hillegas (JIRA)" <ji...@apache.org> on 2009/04/23 18:14:31 UTC
[jira] Created: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Our regression tests use various jar files for which we don't have build scripts.
---------------------------------------------------------------------------------
Key: DERBY-4183
URL: https://issues.apache.org/jira/browse/DERBY-4183
Project: Derby
Issue Type: Test
Components: Test
Affects Versions: 10.6.0.0
Reporter: Rick Hillegas
We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Mark B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark B updated DERBY-4183:
--------------------------
Attachment: status.diff
I'm adding the status changes; currently it looks as though, now that I manually cleared some of the cruft that the tests accumulate in java/testing/system, java/testing/logs, etc all tests are good; there had been some database access trouble in the interim
that makes me think perhaps I should modify the junit-clean script to properly clean that cruft?
as all the test jars are in /java/testing/org/apache/derbyTesting/functionTests, a bzipped tarball of that is 6MB
One more question that arises is, I've managed to give my system a java 1.4.2 alternate installation though the precise interaction of the j14lib / java14compile.classpath properties is a low priority as it stands; do I need to make [java-version-] conditional scripts for compiling the test jars? I'd understand from what I see that providing the test jars are compiled in the java version that handles the tests, then all is good
Best regards
Mark
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-4183:
---------------------------------
Issue & fix info: [Newcomer, Patch Available] (was: [Newcomer])
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Mark B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754217#action_12754217 ]
Mark B commented on DERBY-4183:
-------------------------------
Hi Rick,
1 One class file *is* necessary, in the dcl_emc2l jar file, there's no matching .java source, it seems to me from my reading of the tests that it's a 'wrong' jar to test the ability of derby to recognise such a beast :-)
2 I'll draft a fuller description of the changes; essentially, I've simply unpacked the original jars into appropriate directories as close as possible to the location of the jars, then reconstructed them according to such documentation as I found / my inspection of the originals;
3 I'm seeing that memory depletion all the time, even when I try to test a fresh svn co; I've now cleared the java 1.4.2 that I had put [relatively innocuously I hope - I was thinking it may be useful for testing different compile environments] in a directory under /home, the sun documentation did say that installing it without root privileges it shouldn't affect the global java settings, however unless it was that it's bizarre that my java now looks as though it's acting up; no sign of actual settings changing at all though
I've been developing some java work recently, though when I make time I'll at least try uninstalling / reinstalling my java 6, possibly even reinstalling my OS; the errors were permgen space errors, I went as far as setting the permgen space to 2 gigabytes, no change :-)
so I can't as yet definitively confirm that the patch passes all tests, though I had definitely addressed all the errors that were ant / jar - specific; now until a fresh co tests correctly I definitely won't be blaming the patch for the Memory depletion errors
Best regards
Mark
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Mark B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark B updated DERBY-4183:
--------------------------
Attachment: testjars.diff
Hi,
this updates the patch to include standard .java file headers, as well as more dynamic generation of checksums in case that was necessary; additionally now the classes that are compiled for the test jars are kept clear of the normal compilation happening around them;
so aside from the apparently largely orthogonal test behaviour, that is basically the compilation of the test jars
Best
Mark
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Mark B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754992#action_12754992 ]
Mark B commented on DERBY-4183:
-------------------------------
Hi Knut,
I've already tried altering the main heap space as well as the permgen space, in various different configurations, up to 1024M of 'normal' heap as well as an equal amount of permgen, now I've retried it after uninstalling openjdk, then uninstalling then reinstalling sun-java6; so unless it's the OS then it could only be a very unusual bug :-)
I've tried junit4, in case, now I'll try your precise memory settings; I'd guess I'm looking at reinstalling the OS now though - funny as I did so very recently; progress is relatively slow given the time suites.All takes :-D
Best regards
Mark
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Mark B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark B updated DERBY-4183:
--------------------------
Attachment: testjars.diff
Hi Dag,
well noticed that I was trying to do 2 tasks at once :-)
there's no inconsistency between the patches, it simply so happens that the manually edited diff file containing, as you noticed, some of the changes to the PreparedStatement string handling, would have compiled happily had it contained all of the changes - none the changes is more appropriate; the new diff hopefully is now specific to DERBY-4183
as for the headers, none of the files are really new, they are simply the files from the original pre-compiled jars, as I had tried to avoid large scale changes; though it should be possible to add headers to all the .java files without doing harm; as I say, it looks as though the checksums are mostly wrong / irrelevant, besides I could regenerate new correct checksums now I know how :-D
junit testing seeming a mildly buggy/fragile, I've had one sequence of suites.All virtually completing then giving me memory depletion, now a bizarre port 1537 error
I've sent in an ICLA now so it should figure in a few days
Best regards
Mark
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754965#action_12754965 ]
Knut Anders Hatlen commented on DERBY-4183:
-------------------------------------------
Regarding the memory depletion, the permgen space is just one part of the heap, and increasing its size does not help if you're actually running out of non-permgen heap space. Here are the memory parameters I specify when I run the tests (note that I increase both the max heap space and the max permgen space): -Xmx512M -XX:MaxPermSize=128M
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dag H. Wanvik updated DERBY-4183:
---------------------------------
Issue Type: Improvement (was: Test)
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Rick Hillegas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754206#action_12754206 ]
Rick Hillegas commented on DERBY-4183:
--------------------------------------
Thanks for the patch, Mark. I have a couple comments:
o It looks as though the patch contains a class file: emc.class I suspect that shouldn't be there.
o This is a fairly large patch. Could you describe the changes? Something along the lines of "Extracted the following source code from foo.jar, added license headers." And "Added new build targets foo, bar, wibble which perform the following tasks..."
o Could you describe what tests you ran to verify that the jar files are re-created correctly and that the corresonding regression tests continue to test what they used to test?
Thanks!
-Rick
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Mark B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark B updated DERBY-4183:
--------------------------
Attachment: testjars.diff
Hi,
well derby does seem a nice project, so I'm looking at the automatic compilation of test jars;
I've written a patch that re-compiles for instance the jar found at java/testing/org/apache/derbyTesting/functionTests/testData/v1/j1v1.jar
my work so far raises the relevant questions
- without sight of the original commands it's partly guesswork trying to re-compile the jars
- specifically, in the case of j1v1.jar there are manifest entries for signing; the only reference in the project to ant's signjar command is in the demo directory, java/demo/localcal/build.xml that calls for local signature details;
so it's unclear to me whether I should be signjar-ing the jars, whose key should sign it / whether I simply [as the patch currently does] add the original signature manifest entries to the jar?
Best regards
Mark
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Mark B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark B updated DERBY-4183:
--------------------------
Attachment: testjars.diff
Hi,
so it looks as though the signed jar aspect is mostly a red herring; as I would have hoped a signature won't be necessary for *every* checksum; it seems as though some of the wrong checksums are deliberate - though the checksum aspect perhaps needs documenting as I've mostly simply imported the old [often apparently wrong] checksums as manifest file entries; there is one place that a signed jar is necessary, so I've added ant script to generate the necessary key then sign;
one of the jars is a database, so it really would be unwieldy uncompressed, I've made a zip of it to then compile the jar from;
generally of course I would possibly need an svn branch to commit the binary changes to - alternatively I could make a tarball of the java/testing/ directory; the actual jar changes may safely be omitted, I suppose I'd svn rm the jars themselves as there is now the dynamic generation;
basically for jar files that are compiled from source, I'm creating directories containing the source files, then recompiling from there; I've included the test-jar creation in the 'normal' ant build, though all the test-jar creation could be put into its own directory as an independent jar build;
I'd be happy to hear your comments so far - it needs some additional testing though I seem to have managed the main hurdles
Best regards
Mark
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-4183) Our regression tests use various jar
files for which we don't have build scripts.
Posted by "Dag H. Wanvik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-4183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752276#action_12752276 ]
Dag H. Wanvik commented on DERBY-4183:
--------------------------------------
Thanks for the patch, Mark.
Some superficial comments:
I think some of the changes for your other patch snuck into this one, cf. DatabaseClassLoadingTest? (it did not compile for me, relying on the new idString method of EmbedPreparedStatement)
All new code needs the usual header, btw.
Did anyone encourage you to file a ICLA, btw? http://wiki.apache.org/db-derby/DerbyContributorChecklist . Apache requires this from contributors when a patch gets non-trivial.
> Our regression tests use various jar files for which we don't have build scripts.
> ---------------------------------------------------------------------------------
>
> Key: DERBY-4183
> URL: https://issues.apache.org/jira/browse/DERBY-4183
> Project: Derby
> Issue Type: Improvement
> Components: Test
> Affects Versions: 10.6.0.0
> Reporter: Rick Hillegas
> Attachments: status.diff, testjars.diff, testjars.diff
>
>
> We should add build scripts for these jar files. This is a mini-project suitable for a newcomer.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.