You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/06 01:21:49 UTC

[GitHub] [kafka] mjsax commented on a change in pull request #10072: KAFKA-9274: Throw TaskCorruptedException instead of TimeoutException when TX commit times out

mjsax commented on a change in pull request #10072:
URL: https://github.com/apache/kafka/pull/10072#discussion_r571331549



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/TaskId.java
##########
@@ -32,6 +33,7 @@
     public final int topicGroupId;
     /** The ID of the partition. */
     public final int partition;
+    public Task task;

Review comment:
       I was not happy about it either... Any good suggestions how to do better? I could not come up with a better solution quickly unfortunately. :(
   
   We could add it to the constructor and make it mandatory, but the "splash radios" would be quite large...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org