You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/03 12:59:33 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1331: Improve Spring Boot OneOffJobBootstrap injection
TeslaCN opened a new pull request #1331:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1331
Fixes #1130 .
Changes proposed in this pull request:
- Add property `jobBootstrapBeanName`.
- Add testcase for property `jobBootstrapBeanName`.
- Update example for Spring Boot Starter.
- Update documents of Spring Boot Starter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1331: Improve Spring Boot OneOffJobBootstrap injection
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1331:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu commented on a change in pull request #1331: Improve Spring Boot OneOffJobBootstrap injection
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #1331:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1331#discussion_r464786709
##########
File path: docs/content/user-manual/elasticjob-lite/configuration/spring-boot-starter.cn.md
##########
@@ -46,7 +46,7 @@ elasticjob.reg-center.server-lists=localhost:6181
| 属性名 | 是否必填 |
| --------------------------------- |:-------- |
| elasticJobClass / elasticJobType | 是 |
-| cron | 否 |
+| cron / jobBootstrapBeanName | 否 |
Review comment:
Please separate them into 2 lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org