You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "thomas-dg (via GitHub)" <gi...@apache.org> on 2024/07/15 12:40:03 UTC
[PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
thomas-dg opened a new pull request, #2684:
URL: https://github.com/apache/tinkerpop/pull/2684
<!--
Thanks for contributing! Reminders:
+ TARGET the earliest branch where you want the change
3.6-dev -> 3.6.8 (bugs only)
3.7-dev -> 3.7.3 (non-breaking)
master -> 4.0.0
+ Committers will MERGE the PR forward to newer versions
+ ADD entry to the CHANGELOG.asciidoc for the targeted version
Do not reference a JIRA number there
+ ADD JIRA number to title and link in description
+ PRs requires 3 +1s from committers OR
1 +1 and 7 day wait to merge.
+ MORE details: https://s.apache.org/rtnal
-->
https://issues.apache.org/jira/browse/TINKERPOP-3096
I encountered a log message missing necessary parameters while using the 'Containing' function. The detailed log information is as follows:
`2024/07/14 16:27:28 Error occurred during operation gremlinServerWSProtocol.readLoop(): 'E0703: expected string Key for map, got type='0x%!x(MISSING)''
2024/07/14 16:27:28 Read loop error 'E0703: expected string Key for map, got type='0x%!x(MISSING)'', closing read loop.
2024/07/14 16:27:28 Connection error callback invoked, closing protocol. `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2684:
URL: https://github.com/apache/tinkerpop/pull/2684#issuecomment-2231706679
VOTE +1, thanks for fixing the bug!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2684:
URL: https://github.com/apache/tinkerpop/pull/2684#issuecomment-2233868228
Given this is a small change, I'll be merging this as CTR after the actions pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2684:
URL: https://github.com/apache/tinkerpop/pull/2684#issuecomment-2233900455
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2684?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 80.44%. Comparing base [(`9b46b67`)](https://app.codecov.io/gh/apache/tinkerpop/commit/9b46b6777d2fa250e41daacf2fa4554605aff53a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`71207b6`)](https://app.codecov.io/gh/apache/tinkerpop/commit/71207b68999933cf3eb0db99c6cec7af9fcc575e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 174 commits behind head on 3.7-dev.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 3.7-dev #2684 +/- ##
=============================================
+ Coverage 76.14% 80.44% +4.29%
=============================================
Files 1084 27 -1057
Lines 65160 4985 -60175
Branches 7285 0 -7285
=============================================
- Hits 49616 4010 -45606
+ Misses 12839 773 -12066
+ Partials 2705 202 -2503
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tinkerpop/pull/2684?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TINKERPOP-3096: improvement: add necessary parameters for logging to fix '%!x(MISSING)' output issue in gremlin-go [tinkerpop]
Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #2684:
URL: https://github.com/apache/tinkerpop/pull/2684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org