[jira] [Updated] (SOLR-5488) Fix up test failures for Analytics Component

["Steven Bower (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Bower updated SOLR-5488:
-------------------------------

    Attachment: SOLR-5488.patch

Attached is a patch (to trunk) that fixes a few issues as well as adding some additional checks/exceptions/logging:

* check that getStatResult resturns non-null/empty strings. There were a few tests that were actually failing but not reporting as such (eg get to string stats and concat them but when both werent there it would concat 2 empty strings and succeed
* When we fail to create an accumulator it was just println'ing the exception vs logging it so we can see a full stack trace
* Moved call to docs.getTopFilter() out of the loop through analytics request. There is no need to rebuild this each time. In fact I may refactor this entire section in the future (once this all works)
* Updated FunctionTest as some date based tests where using the STRING VAL_TYPE instead of DATE

> Fix up test failures for Analytics Component
> --------------------------------------------
>
>                 Key: SOLR-5488
>                 URL: https://issues.apache.org/jira/browse/SOLR-5488
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.0, 4.7
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>         Attachments: SOLR-5488.patch, SOLR-5488.patch, SOLR-5488.patch, SOLR-5488.patch
>
>
> The analytics component has a few test failures, perhaps environment-dependent. This is just to collect the test fixes in one place for convenience when we merge back into 4.x



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org