You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by jaydoane <gi...@git.apache.org> on 2015/11/06 03:16:51 UTC
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
GitHub user jaydoane opened a pull request:
https://github.com/apache/couchdb-couch/pull/126
Remove lager and goldrush from default list of apps started by test_util:start_couch/2
Also, create a common list of default apps that is started and stopped consistently
COUCHDB-2872
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-couch 2872-cleanup-start_couch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit 94088aded2c84c75d95723950d4cc5ed154758d6
Author: Jay Doane <ja...@gmail.com>
Date: 2015-11-06T02:13:30Z
Remove lager and goldrush from default list of apps started by test_util:start_couch/2
Also, create a common list of default apps that is started and stopped consistently
COUCHDB-2872
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the pull request:
https://github.com/apache/couchdb-couch/pull/126#issuecomment-175301505
Also tested. Used this patch to pick up pr changes:
```
-{couch, "couch", "f33f9fa1281fd6c50a86cb9853bd2d9ec2dd007c"},
+%{couch, "couch", "f33f9fa1281fd6c50a86cb9853bd2d9ec2dd007c"},
+{couch, {url, "https://github.com/cloudant/couchdb-couch.git"},
+ "010704ad9ddfd8bbd28c91e6c87484ef25afa296"},
```
Ran on master branch of couchdb, Mac OS X, Erlang 18. All tests pass and output looked good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-couch/pull/126#issuecomment-154489058
@iilyak, I'm sorry for being so dense, but can you go into a little more detail how this patch might trigger the cyclic dependency you mentioned above?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/126#issuecomment-173338462
> However you a right the problem I mentioned would exhibit itself regardless of this particular change
Are there any other obstacles?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/126#issuecomment-154482467
@kxepal: We have a very bad cyclic dependency between [couch_log](https://github.com/apache/couchdb-couch-log/blob/master/src/couch_log.erl#L47) and [couch_stats](https://github.com/apache/couchdb-couch-stats/blob/master/src/couch_stats.erl#L118). The problem could happen if you would make a typo in metric name and run a test suite. We need to test for that before we merge this (either manually or by implementing test case).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/126#issuecomment-175571125
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by tonysun83 <gi...@git.apache.org>.
Github user tonysun83 commented on the pull request:
https://github.com/apache/couchdb-couch/pull/126#issuecomment-175191141
I ran some make checks with your branch and the tests I ran pass. +1 for me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by jaydoane <gi...@git.apache.org>.
Github user jaydoane commented on the pull request:
https://github.com/apache/couchdb-couch/pull/126#issuecomment-173460134
I have rebased. If there are no other objections, can we get a +1?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/126#issuecomment-154443386
Funny that we still start goldrush and lager for couch_log_lager_backend implicitly somewhere else.
@iilyak @eiri do you remember if this will not bite us somewhere else in future?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: Remove lager and goldrush from default...
Posted by iilyak <gi...@git.apache.org>.
Github user iilyak commented on the pull request:
https://github.com/apache/couchdb-couch/pull/126#issuecomment-154569604
@jaydoane: The cyclic dependency could be triggered with following:
1. make a syntactic error in `couch-log/priv/stats_descriptions.cfg`
2. `couch_stats_aggregator` would try to reload metrics. The reload logic skips all metrics defined in a file we cannot read (using `file:consult`)
3. Any attempt to log anything using `couch_log:<level>` would cause [`couch_log:notice("unknown metric: ~p", [Name])`](https://github.com/apache/couchdb-couch-stats/blob/master/src/couch_stats.erl#L118)
4. `couch_log:notice` in it's turn calls [`couch_stats:increment()`](https://github.com/apache/couchdb-couch-log/blob/master/src/couch_log.erl#L47)
5. we would have an infinite loop which will bring the node down.
However you a right the problem I mentioned would exhibit itself regardless of this particular change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---