You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2018/08/13 22:22:45 UTC
Review Request 68326: Introduced FUTURE_EXITED and DROP_EXITED in
libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68326/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Meng Zhu.
Repository: mesos
Description
-------
These extend the existing event expectations to handle `ExitedEvent`.
Diffs
-----
3rdparty/libprocess/include/process/gmock.hpp e30f5863d3d028fa320ca4b674a6c7a499c15991
Diff: https://reviews.apache.org/r/68326/diff/1/
Testing
-------
Added a test in a subsequent patch.
Thanks,
Benjamin Mahler
Re: Review Request 68326: Introduced FUTURE_EXITED and DROP_EXITED in
libprocess.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68326/#review207280
-----------------------------------------------------------
Ship it!
This looks good to me now!
Disclaimer: I don't know this part of our codebase that well, so I'll feel better if another libprocess maintainer takes a look.
- Gastón Kleiman
On Aug. 13, 2018, 3:22 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68326/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 3:22 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These extend the existing event expectations to handle `ExitedEvent`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gmock.hpp e30f5863d3d028fa320ca4b674a6c7a499c15991
>
>
> Diff: https://reviews.apache.org/r/68326/diff/3/
>
>
> Testing
> -------
>
> Added a test in a subsequent patch.
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 68326: Introduced FUTURE_EXITED and DROP_EXITED in
libprocess.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68326/#review207254
-----------------------------------------------------------
3rdparty/libprocess/include/process/gmock.hpp
Lines 711 (patched)
<https://reviews.apache.org/r/68326/#comment290586>
Nit: should we be consistent with `FutureMessage` and name the template typenames `From` and `To`?
- Gastón Kleiman
On Aug. 13, 2018, 3:22 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68326/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2018, 3:22 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Meng Zhu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These extend the existing event expectations to handle `ExitedEvent`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gmock.hpp e30f5863d3d028fa320ca4b674a6c7a499c15991
>
>
> Diff: https://reviews.apache.org/r/68326/diff/2/
>
>
> Testing
> -------
>
> Added a test in a subsequent patch.
>
>
> Thanks,
>
> Benjamin Mahler
>
>