[GitHub] kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

[GitBox <gi...@apache.org>]

kr-arjun commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls
URL: https://github.com/apache/drill/pull/1405#issuecomment-410326307
 
 
   @HanumathRao  I have modified variable names as per review comments. I didn't include assert check for types length while checking name ending with '.drill' as it is causing test failures. This assertion check fails for the scenario where complete view name is used in querying as in below test.
   
   https://github.com/apache/drill/blob/master/exec/java-exec/src/test/java/org/apache/drill/exec/sql/TestViewSupport.java#L748
   
    For '*.drill' files, the type check is being done later in the getDrillFiles method. I have modified the method comments to indicate this behavior that types checking is done only for case name does not end with .drill. Please let me know if this is okay.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services