[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3444: Evaluate expressions after type coercion

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #3444:
URL: https://github.com/apache/arrow-datafusion/pull/3444#discussion_r967840953


##########
datafusion/optimizer/src/type_coercion.rs:
##########
@@ -64,7 +66,15 @@ impl OptimizerRule for TypeCoercion {
             _ => DFSchemaRef::new(DFSchema::empty()),
         };
 
-        let mut expr_rewrite = TypeCoercionRewriter { schema };
+        let mut execution_props = ExecutionProps::new();
+        execution_props.query_execution_start_time =
+            optimizer_config.query_execution_start_time;
+        let const_evaluator = ConstEvaluator::try_new(&execution_props)?;

Review Comment:
   We could move this initialization into a constructor to avoid doing it per plan.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org