You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/20 20:17:53 UTC
[GitHub] [spark] iRakson opened a new pull request #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
iRakson opened a new pull request #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
Introduced a new parameter `emptyCollection` for `CreateMap` and `CreateArray` functiion to remove dependency on SQLConf.get.
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
This allows to avoid the issue when the configuration change between different phases of planning, and this can silently break a query plan which can lead to crashes or data corruption.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce any user-facing change?
No
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
### How was this patch tested?
Existing UTs.
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589520236
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590220360
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590304221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118857/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593988553
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590304221
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118857/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590872127
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118912/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590747098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23661/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590749446
**[Test build #118912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118912/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595629198
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119437/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590698882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23648/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590736317
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589897858
**[Test build #118807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118807/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#discussion_r382422992
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -553,10 +553,14 @@ object TypeCoercion {
// Skip nodes who's children have not been resolved yet.
case e if !e.childrenResolved => e
- case a @ CreateArray(children) if !haveSameType(children.map(_.dataType)) =>
+ case a @ CreateArray(children, useStringTypeWhenEmpty)
+ if !haveSameType(children.map(_.dataType)) =>
val types = children.map(_.dataType)
findWiderCommonType(types) match {
- case Some(finalDataType) => CreateArray(children.map(castIfNotSameType(_, finalDataType)))
+ case Some(finalDataType) => CreateArray(
Review comment:
nit: `a.copy(children = ...)`, then we don't need the `useStringTypeWhenEmpty` parameter and can just write `case a @ CreateArray(children, _)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595553129
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24174/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589289212
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590303779
**[Test build #118857 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118857/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595664494
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589919754
**[Test build #118807 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118807/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590872127
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118912/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593864364
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590747098
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23661/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589898013
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589521877
**[Test build #118761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118761/testReport)** for PR 27657 at commit [`7bbf40e`](https://github.com/apache/spark/commit/7bbf40e1451f96eb97a479d407735c81f6742279).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#discussion_r382408999
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
##########
@@ -275,9 +275,9 @@ trait GetArrayItemUtil {
if (ordinal.foldable && !ordinal.nullable) {
val intOrdinal = ordinal.eval().asInstanceOf[Number].intValue()
child match {
- case CreateArray(ar) if intOrdinal < ar.length =>
+ case CreateArray(ar, emptyCollection) if intOrdinal < ar.length =>
Review comment:
You can just write `case CreateArray(ar, _)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593987845
**[Test build #119221 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119221/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595629196
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590304213
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593862167
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589898014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23557/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589507438
**[Test build #118755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118755/testReport)** for PR 27657 at commit [`37b26ac`](https://github.com/apache/spark/commit/37b26ac407518073508d90f1a4991d6a84cfe70e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590875394
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23669/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589670041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118770/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593864378
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23960/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589507438
**[Test build #118755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118755/testReport)** for PR 27657 at commit [`37b26ac`](https://github.com/apache/spark/commit/37b26ac407518073508d90f1a4991d6a84cfe70e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589526219
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589556263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23522/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589919839
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118807/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590872902
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#discussion_r383259854
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -37,7 +37,12 @@ import org.apache.spark.unsafe.types.UTF8String
> SELECT _FUNC_(1, 2, 3);
[1,2,3]
""")
-case class CreateArray(children: Seq[Expression]) extends Expression {
+case class CreateArray(children: Seq[Expression], useStringTypeWhenEmpty: Boolean)
Review comment:
we need to override `stringArgs` to exclude the new `useStringTypeWhenEmpty` parameter, otherwise the EXPLAIN result changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590698882
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23648/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589506627
ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589520239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23512/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589898013
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589526227
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118761/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590874654
**[Test build #118921 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118921/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589521877
**[Test build #118761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118761/testReport)** for PR 27657 at commit [`7bbf40e`](https://github.com/apache/spark/commit/7bbf40e1451f96eb97a479d407735c81f6742279).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590736317
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590736042
**[Test build #118899 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118899/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593623869
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595627913
**[Test build #119437 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119437/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589669250
**[Test build #118770 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118770/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590875386
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590220369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23606/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595553124
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595552853
**[Test build #119437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119437/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589289212
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589670033
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590698543
**[Test build #118899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118899/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589289764
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590220369
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23606/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589543551
**[Test build #118755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118755/testReport)** for PR 27657 at commit [`37b26ac`](https://github.com/apache/spark/commit/37b26ac407518073508d90f1a4991d6a84cfe70e).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class CreateArray(children: Seq[Expression], emptyCollection: Boolean) extends Expression `
* `case class CreateMap(children: Seq[Expression], emptyCollection: Boolean) extends Expression `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593988564
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119221/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590875386
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590872110
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595552853
**[Test build #119437 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119437/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589520239
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23512/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590746710
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590219195
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589507695
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23506/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589670041
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118770/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590736326
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118899/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593864378
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23960/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#discussion_r382408862
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -37,7 +37,11 @@ import org.apache.spark.unsafe.types.UTF8String
> SELECT _FUNC_(1, 2, 3);
[1,2,3]
""")
-case class CreateArray(children: Seq[Expression]) extends Expression {
+case class CreateArray(children: Seq[Expression], emptyCollection: Boolean) extends Expression {
Review comment:
how about `useStringTypeWhenEmpty`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590871236
**[Test build #118912 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118912/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590698877
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589543705
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118755/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589526122
**[Test build #118761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118761/testReport)** for PR 27657 at commit [`7bbf40e`](https://github.com/apache/spark/commit/7bbf40e1451f96eb97a479d407735c81f6742279).
* This patch **fails to generate documentation**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class CreateArray(children: Seq[Expression], useStringTypeWhenEmpty: Boolean)`
* `case class CreateMap(children: Seq[Expression], useStringTypeWhenEmpty: Boolean)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589897858
**[Test build #118807 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118807/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589507695
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23506/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590747091
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590219934
**[Test build #118857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118857/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
iRakson commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595665295
Thanks everyone for reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589896973
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a change in pull request #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#discussion_r382243331
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
##########
@@ -275,9 +275,9 @@ trait GetArrayItemUtil {
if (ordinal.foldable && !ordinal.nullable) {
val intOrdinal = ordinal.eval().asInstanceOf[Number].intValue()
child match {
- case CreateArray(ar) if intOrdinal < ar.length =>
+ case CreateArray(ar, emptyCollection) if intOrdinal < ar.length =>
Review comment:
Is emptyCollection not used, right? You can add unapply to `CreateArray` and avoid modification of this place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593863706
**[Test build #119221 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119221/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590749446
**[Test build #118912 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118912/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589543695
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589919835
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593988564
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119221/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589919835
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593864364
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589556263
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23522/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590220360
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590875394
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23669/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590219934
**[Test build #118857 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118857/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589543695
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589507687
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589526227
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118761/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589520236
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590736326
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118899/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590747091
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590872110
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595629198
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119437/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590698543
**[Test build #118899 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118899/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589555764
**[Test build #118770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118770/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593863706
**[Test build #119221 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119221/testReport)** for PR 27657 at commit [`e255906`](https://github.com/apache/spark/commit/e2559060d8fd99078d9b25472c45072867531fe8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589289764
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595629196
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589898014
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23557/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] iRakson commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
iRakson commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589292708
cc @MaxGekk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590698877
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-590304213
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589556255
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589526219
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589670033
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589543705
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118755/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589556255
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589555764
**[Test build #118770 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118770/testReport)** for PR 27657 at commit [`689722a`](https://github.com/apache/spark/commit/689722afbb426fa42ae7370e1cd5e59006ef2b4b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589660795
Can you add some end-to-end tests to check that no change happens in output data types even when the conf updated?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595553129
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24174/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595553124
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27657:
[SPARK-30899]: CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#discussion_r382423049
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -606,7 +610,9 @@ object TypeCoercion {
case None => m.values
}
- CreateMap(newKeys.zip(newValues).flatMap { case (k, v) => Seq(k, v) })
+ CreateMap(
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-595552407
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899][SQL]
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-593988553
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589919839
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118807/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27657: [SPARK-30899]:
CreateArray/CreateMap's data type should not depend on SQLConf.get
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27657: [SPARK-30899]: CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#issuecomment-589507687
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #27657:
[SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on
SQLConf.get
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #27657: [SPARK-30899][SQL] CreateArray/CreateMap's data type should not depend on SQLConf.get
URL: https://github.com/apache/spark/pull/27657#discussion_r400617350
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -37,16 +37,23 @@ import org.apache.spark.unsafe.types.UTF8String
> SELECT _FUNC_(1, 2, 3);
[1,2,3]
""")
-case class CreateArray(children: Seq[Expression]) extends Expression {
+case class CreateArray(children: Seq[Expression], useStringTypeWhenEmpty: Boolean)
Review comment:
@iRakson When you update the code, do not forget update the PR description, which will be part of the commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org