You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Chris Bowditch <bo...@hotmail.com> on 2003/11/07 12:13:41 UTC

space-before in 1.0Dev

Hi Glen and other devs,

I'm responding to an earlier message where you said:

<quote>
Another issue I was working on last weekend--still
unsolved--was that in 1.0 layout, fo:block
space-before is being added to the top of *each* page
that the block consumes (instead of just once at the
top of the block).  This may take some time to
fix--I'll keep working on it.
</quote>

how far did you get with this? I had a spare few minutes and had a look as 
well. I may be well off base with this as I'm new to the code:

The BlockLayoutManager.addAreas seems to be responsible for adding space 
before/after. Currently there is no check to see whether or not this is the 
first/last call to addAreas. Is the LayoutContext object supposed to be the 
mechanism for checking such state? Currently LayoutContexts in the parent 
FlowLayoutManager are created with flags=0. Do you think it should be 
setting FIRST, LAST, etc?

Any insight would be appreciated,

Chris

_________________________________________________________________
Find a cheaper internet access deal - choose one to suit you. 
http://www.msn.co.uk/internetaccess


Re: space-before in 1.0Dev

Posted by "J.Pietschmann" <j3...@yahoo.de>.
Chris Bowditch wrote:
> The BlockLayoutManager.addAreas seems to be responsible for adding space 
> before/after. Currently there is no check to see whether or not this is 
> the first/last call to addAreas. Is the LayoutContext object supposed to 
> be the mechanism for checking such state?

I think so.

J.Pietschmann


Re: space-before in 1.0Dev

Posted by Glen Mazza <gr...@yahoo.com>.
--- Chris Bowditch <bo...@hotmail.com> wrote:
> Is the LayoutContext
> object supposed to be the 
> mechanism for checking such state? Currently
> LayoutContexts in the parent 
> FlowLayoutManager are created with flags=0. Do you
> think it should be 
> setting FIRST, LAST, etc?
> 

That *could* be a solution--I added toString() methods
in the LayoutContext to help track the state of values
in that class.

Glen

__________________________________
Do you Yahoo!?
Protect your identity with Yahoo! Mail AddressGuard
http://antispam.yahoo.com/whatsnewfree