You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by se...@apache.org on 2021/02/15 02:11:33 UTC

[openmeetings] 01/01: Addtional logging for certain scenarios that could lead to performance or application issues.

This is an automated email from the ASF dual-hosted git repository.

sebawagner pushed a commit to branch feature/additional-logging-for-capturing-warnings
in repository https://gitbox.apache.org/repos/asf/openmeetings.git

commit 0dd209f6e436abf369dd8503b555ade168f43b00
Author: Sebastian Wagner <se...@gmail.com>
AuthorDate: Mon Feb 15 15:11:10 2021 +1300

    Addtional logging for certain scenarios that could lead to performance or application issues.
---
 .../main/java/org/apache/openmeetings/core/remote/KStream.java    | 8 ++++++++
 .../java/org/apache/openmeetings/core/remote/StreamProcessor.java | 2 ++
 2 files changed, 10 insertions(+)

diff --git a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
index 47d8201..af245ea 100644
--- a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
+++ b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/KStream.java
@@ -198,6 +198,8 @@ public class KStream extends AbstractStream implements ISipCallbacks {
 		});
 		outgoingMedia.addMediaFlowInStateChangeListener(evt -> log.warn("Media Flow IN :: {}, {}, {}, sid {}, uid {}"
 				, evt.getState(), evt.getMediaType(), evt.getSource(), sid, uid));
+		outgoingMedia.addMediaStateChangedListener(evt -> log.warn("Media StateChanged :: {}, {}, {}, sid {}, uid {}"
+				, evt.getSource(), evt.getOldState(), evt.getNewState(), sid, uid));
 		if (!sipClient) {
 			addListener(sd.getSid(), sd.getUid(), sdpOffer);
 			addSipProcessor(kRoom.getSipCount());
@@ -313,6 +315,9 @@ public class KStream extends AbstractStream implements ISipCallbacks {
 					.put("uid", KStream.this.uid)
 					.put(PARAM_CANDIDATE, convert(JsonUtils.toJsonObject(evt.getCandidate()))))
 				);
+		endpoint.addIceComponentStateChangeListener(evt -> 
+				log.info("Ice Component change listener state {} ", evt.getState()));
+		
 		return endpoint;
 	}
 
@@ -507,6 +512,7 @@ public class KStream extends AbstractStream implements ISipCallbacks {
 	public void addCandidate(IceCandidate candidate, String uid) {
 		if (this.uid.equals(uid)) {
 			if (!(outgoingMedia instanceof WebRtcEndpoint)) {
+				log.warn("addCandidate outgoingMedia no WebRtcEndpoint, Add candidate for {}, listener found ? {}", uid);
 				return;
 			}
 			((WebRtcEndpoint)outgoingMedia).addIceCandidate(candidate);
@@ -515,6 +521,8 @@ public class KStream extends AbstractStream implements ISipCallbacks {
 			log.debug("Add candidate for {}, listener found ? {}", uid, endpoint != null);
 			if (endpoint != null) {
 				endpoint.addIceCandidate(candidate);
+			} else {
+				log.warn("addCandidate endpoint is null, Add candidate for {}, listener found ? {}", uid);
 			}
 		}
 	}
diff --git a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
index 58eab69..777b04f 100644
--- a/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
+++ b/openmeetings-core/src/main/java/org/apache/openmeetings/core/remote/StreamProcessor.java
@@ -125,6 +125,8 @@ public class StreamProcessor implements IStreamProcessor {
 								, candidate.getInt("sdpMLineIndex"));
 						sender.addCandidate(cand, msg.getString("luid"));
 					}
+				} else {
+					log.warn("onIceCandidate could not find sender, uid {}", uid);
 				}
 				break;
 			case "addListener":