You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Kirby Zhou <ki...@gmail.com> on 2024/03/21 09:21:16 UTC
Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/
-----------------------------------------------------------
(Updated 三月 21, 2024, 9:21 a.m.)
Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan Periasamy.
Changes
-------
sync with HEAD
Bugs: ranger-3998
https://issues.apache.org/jira/browse/ranger-3998
Repository: ranger
Description
-------
AWS KMS is widely used by many customers.
Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
Diffs (updated)
-----
distro/src/main/assembly/kms.xml 77f61b917
kms/config/kms-webapp/dbks-site.xml 258d331d8
kms/pom.xml 2739bb81a
kms/scripts/install.properties 5f5df9b1f
kms/scripts/setup.sh 0cce478fd
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 429d1ce45
kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 1f0125967
Diff: https://reviews.apache.org/r/74259/diff/7/
Changes: https://reviews.apache.org/r/74259/diff/6-7/
Testing
-------
Tested under macos-13 and centos-8
File Attachments
----------------
0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
Thanks,
Kirby Zhou
Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/#review226383
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Shah
On March 23, 2024, 2:20 a.m., Kirby Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74259/
> -----------------------------------------------------------
>
> (Updated March 23, 2024, 2:20 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: ranger-3998
> https://issues.apache.org/jira/browse/ranger-3998
>
>
> Repository: ranger
>
>
> Description
> -------
>
> AWS KMS is widely used by many customers.
> Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/kms.xml 77f61b917
> kms/config/kms-webapp/dbks-site.xml 258d331d8
> kms/pom.xml 0b37ce52d
> kms/scripts/install.properties 5f5df9b1f
> kms/scripts/setup.sh 0cce478fd
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java PRE-CREATION
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 429d1ce45
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 1f0125967
>
>
> Diff: https://reviews.apache.org/r/74259/diff/8/
>
>
> Testing
> -------
>
> Tested under macos-13 and centos-8
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
> https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
>
>
> Thanks,
>
> Kirby Zhou
>
>
Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/#review226365
-----------------------------------------------------------
Hi Kirby,
As mentioned in Apache Jira,
Can you please share the documentation link for this feature.
Thanks
- Dhaval Shah
On March 23, 2024, 2:20 a.m., Kirby Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74259/
> -----------------------------------------------------------
>
> (Updated March 23, 2024, 2:20 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: ranger-3998
> https://issues.apache.org/jira/browse/ranger-3998
>
>
> Repository: ranger
>
>
> Description
> -------
>
> AWS KMS is widely used by many customers.
> Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/kms.xml 77f61b917
> kms/config/kms-webapp/dbks-site.xml 258d331d8
> kms/pom.xml 0b37ce52d
> kms/scripts/install.properties 5f5df9b1f
> kms/scripts/setup.sh 0cce478fd
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java PRE-CREATION
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 429d1ce45
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 1f0125967
>
>
> Diff: https://reviews.apache.org/r/74259/diff/8/
>
>
> Testing
> -------
>
> Tested under macos-13 and centos-8
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
> https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
>
>
> Thanks,
>
> Kirby Zhou
>
>
Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS
Posted by Kirby Zhou <ki...@gmail.com>.
> On 三月 27, 2024, 11:43 a.m., Dhaval Shah wrote:
> > kms/pom.xml
> > Lines 425 (patched)
> > <https://reviews.apache.org/r/74259/diff/8/?file=2286227#file2286227line425>
> >
> > Initialize the version
This version is already in ranger's pom.
https://github.com/apache/ranger/commit/27456a9c634cd3747da890a34d1d765d91685224
- Kirby
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/#review226354
-----------------------------------------------------------
On 三月 23, 2024, 2:20 a.m., Kirby Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74259/
> -----------------------------------------------------------
>
> (Updated 三月 23, 2024, 2:20 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: ranger-3998
> https://issues.apache.org/jira/browse/ranger-3998
>
>
> Repository: ranger
>
>
> Description
> -------
>
> AWS KMS is widely used by many customers.
> Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/kms.xml 77f61b917
> kms/config/kms-webapp/dbks-site.xml 258d331d8
> kms/pom.xml 0b37ce52d
> kms/scripts/install.properties 5f5df9b1f
> kms/scripts/setup.sh 0cce478fd
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java PRE-CREATION
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 429d1ce45
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 1f0125967
>
>
> Diff: https://reviews.apache.org/r/74259/diff/8/
>
>
> Testing
> -------
>
> Tested under macos-13 and centos-8
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
> https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
>
>
> Thanks,
>
> Kirby Zhou
>
>
Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/#review226354
-----------------------------------------------------------
kms/pom.xml
Lines 425 (patched)
<https://reviews.apache.org/r/74259/#comment314594>
Initialize the version
- Dhaval Shah
On March 23, 2024, 2:20 a.m., Kirby Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74259/
> -----------------------------------------------------------
>
> (Updated March 23, 2024, 2:20 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: ranger-3998
> https://issues.apache.org/jira/browse/ranger-3998
>
>
> Repository: ranger
>
>
> Description
> -------
>
> AWS KMS is widely used by many customers.
> Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/kms.xml 77f61b917
> kms/config/kms-webapp/dbks-site.xml 258d331d8
> kms/pom.xml 0b37ce52d
> kms/scripts/install.properties 5f5df9b1f
> kms/scripts/setup.sh 0cce478fd
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java PRE-CREATION
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 429d1ce45
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 1f0125967
>
>
> Diff: https://reviews.apache.org/r/74259/diff/8/
>
>
> Testing
> -------
>
> Tested under macos-13 and centos-8
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
> https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
>
>
> Thanks,
>
> Kirby Zhou
>
>
Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS
Posted by Kirby Zhou <ki...@gmail.com>.
> On 三月 27, 2024, 11:36 a.m., Dhaval Shah wrote:
> > distro/src/main/assembly/kms.xml
> > Line 182 (original), 185 (patched)
> > <https://reviews.apache.org/r/74259/diff/8/?file=2286225#file2286225line185>
> >
> > Do we need tencent KMS dependency for AWS KMS?
This is about streamlining dependencies to reduce the risk of conflicts.
- Kirby
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/#review226353
-----------------------------------------------------------
On 三月 23, 2024, 2:20 a.m., Kirby Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74259/
> -----------------------------------------------------------
>
> (Updated 三月 23, 2024, 2:20 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: ranger-3998
> https://issues.apache.org/jira/browse/ranger-3998
>
>
> Repository: ranger
>
>
> Description
> -------
>
> AWS KMS is widely used by many customers.
> Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/kms.xml 77f61b917
> kms/config/kms-webapp/dbks-site.xml 258d331d8
> kms/pom.xml 0b37ce52d
> kms/scripts/install.properties 5f5df9b1f
> kms/scripts/setup.sh 0cce478fd
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java PRE-CREATION
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 429d1ce45
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 1f0125967
>
>
> Diff: https://reviews.apache.org/r/74259/diff/8/
>
>
> Testing
> -------
>
> Tested under macos-13 and centos-8
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
> https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
>
>
> Thanks,
>
> Kirby Zhou
>
>
Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/#review226353
-----------------------------------------------------------
distro/src/main/assembly/kms.xml
Line 182 (original), 185 (patched)
<https://reviews.apache.org/r/74259/#comment314593>
Do we need tencent KMS dependency for AWS KMS?
- Dhaval Shah
On March 23, 2024, 2:20 a.m., Kirby Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74259/
> -----------------------------------------------------------
>
> (Updated March 23, 2024, 2:20 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: ranger-3998
> https://issues.apache.org/jira/browse/ranger-3998
>
>
> Repository: ranger
>
>
> Description
> -------
>
> AWS KMS is widely used by many customers.
> Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/kms.xml 77f61b917
> kms/config/kms-webapp/dbks-site.xml 258d331d8
> kms/pom.xml 0b37ce52d
> kms/scripts/install.properties 5f5df9b1f
> kms/scripts/setup.sh 0cce478fd
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java PRE-CREATION
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 429d1ce45
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 1f0125967
>
>
> Diff: https://reviews.apache.org/r/74259/diff/8/
>
>
> Testing
> -------
>
> Tested under macos-13 and centos-8
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
> https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
>
>
> Thanks,
>
> Kirby Zhou
>
>
Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS
Posted by Kirby Zhou <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/
-----------------------------------------------------------
(Updated 三月 23, 2024, 2:20 a.m.)
Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan Periasamy.
Changes
-------
Add missing file
Bugs: ranger-3998
https://issues.apache.org/jira/browse/ranger-3998
Repository: ranger
Description
-------
AWS KMS is widely used by many customers.
Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
Diffs (updated)
-----
distro/src/main/assembly/kms.xml 77f61b917
kms/config/kms-webapp/dbks-site.xml 258d331d8
kms/pom.xml 0b37ce52d
kms/scripts/install.properties 5f5df9b1f
kms/scripts/setup.sh 0cce478fd
kms/src/main/java/org/apache/hadoop/crypto/key/RangerAWSKMSProvider.java PRE-CREATION
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 429d1ce45
kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 1f0125967
Diff: https://reviews.apache.org/r/74259/diff/8/
Changes: https://reviews.apache.org/r/74259/diff/7-8/
Testing
-------
Tested under macos-13 and centos-8
File Attachments
----------------
0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
Thanks,
Kirby Zhou
Re: Review Request 74259: RANGER-3998: Support Ranger KMS integration with AWS KMS
Posted by Dhaval Shah <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74259/#review226343
-----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java
Lines 173 (patched)
<https://reviews.apache.org/r/74259/#comment314588>
RangerAWSKMSProvider class is missing in last uploaded patch.
Can you please update the patch with RangerAWSKMSProvider.java
- Dhaval Shah
On March 21, 2024, 9:21 a.m., Kirby Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74259/
> -----------------------------------------------------------
>
> (Updated March 21, 2024, 9:21 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Mateen Mansoori, Mehul Parikh, Pradeep Agrawal, VaradreawiZTV VaradreawiZTV, Vishal Suvagia, and Velmurugan Periasamy.
>
>
> Bugs: ranger-3998
> https://issues.apache.org/jira/browse/ranger-3998
>
>
> Repository: ranger
>
>
> Description
> -------
>
> AWS KMS is widely used by many customers.
> Therefore, RangerKMS should support hosting MasterKey to AWS KMS.
>
>
> Diffs
> -----
>
> distro/src/main/assembly/kms.xml 77f61b917
> kms/config/kms-webapp/dbks-site.xml 258d331d8
> kms/pom.xml 2739bb81a
> kms/scripts/install.properties 5f5df9b1f
> kms/scripts/setup.sh 0cce478fd
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java 429d1ce45
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerTencentKMSProvider.java 1f0125967
>
>
> Diff: https://reviews.apache.org/r/74259/diff/7/
>
>
> Testing
> -------
>
> Tested under macos-13 and centos-8
>
>
> File Attachments
> ----------------
>
> 0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
> https://reviews.apache.org/media/uploaded/files/2023/04/07/6499bf0e-af49-4eae-8636-f183f0fab3d7__0001-RANGER-3998-KMS-integration-with-AWS-KMS.patch
>
>
> Thanks,
>
> Kirby Zhou
>
>