You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by ra...@apache.org on 2024/02/19 04:35:38 UTC
(hbase) branch branch-3 updated: HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS (#5558)
This is an automated email from the ASF dual-hosted git repository.
rajeshbabu pushed a commit to branch branch-3
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-3 by this push:
new 43eb0b7e83b HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS (#5558)
43eb0b7e83b is described below
commit 43eb0b7e83b23f4e7ef6dc5c6d43275f2da16da3
Author: Kerasone <42...@users.noreply.github.com>
AuthorDate: Mon Feb 19 12:21:07 2024 +0800
HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS (#5558)
HBASE-28238 rpcservice should perform some important admin operation to priority ADMIN_QOS (#5558)
Co-authored-by: selina.yan <se...@huolala.cn>
---
.../src/main/java/org/apache/hadoop/hbase/HBaseRpcServicesBase.java | 1 +
.../main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java | 2 ++
.../java/org/apache/hadoop/hbase/regionserver/TestRSQosFunction.java | 3 +++
3 files changed, 6 insertions(+)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseRpcServicesBase.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseRpcServicesBase.java
index 291b38acb32..b2a0e780362 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseRpcServicesBase.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/HBaseRpcServicesBase.java
@@ -310,6 +310,7 @@ public abstract class HBaseRpcServicesBase<S extends HBaseServerBase<?>>
}
@Override
+ @QosPriority(priority = HConstants.ADMIN_QOS)
public UpdateConfigurationResponse updateConfiguration(RpcController controller,
UpdateConfigurationRequest request) throws ServiceException {
try {
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
index 0538b9706e8..4926aa30c8a 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
@@ -1554,6 +1554,7 @@ public class RSRpcServices extends HBaseRpcServicesBase<HRegionServer>
}
@Override
+ @QosPriority(priority = HConstants.ADMIN_QOS)
public CompactionSwitchResponse compactionSwitch(RpcController controller,
CompactionSwitchRequest request) throws ServiceException {
rpcPreCheck("compactionSwitch");
@@ -2232,6 +2233,7 @@ public class RSRpcServices extends HBaseRpcServicesBase<HRegionServer>
* @param request the request
*/
@Override
+ @QosPriority(priority = HConstants.ADMIN_QOS)
public RollWALWriterResponse rollWALWriter(final RpcController controller,
final RollWALWriterRequest request) throws ServiceException {
try {
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSQosFunction.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSQosFunction.java
index c6bd8967e12..15ee32397e9 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSQosFunction.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSQosFunction.java
@@ -72,5 +72,8 @@ public class TestRSQosFunction extends QosTestBase {
checkMethod(conf, "CloseRegion", HConstants.ADMIN_QOS, qosFunction);
checkMethod(conf, "CompactRegion", HConstants.ADMIN_QOS, qosFunction);
checkMethod(conf, "FlushRegion", HConstants.ADMIN_QOS, qosFunction);
+ checkMethod(conf, "UpdateConfiguration", HConstants.ADMIN_QOS, qosFunction);
+ checkMethod(conf, "CompactionSwitch", HConstants.ADMIN_QOS, qosFunction);
+ checkMethod(conf, "RollWALWriter", HConstants.ADMIN_QOS, qosFunction);
}
}