[jira] [Commented] (HDFS-12609) Ozone: SCM: Refactoring of chill mode logic in NodeManager

["Chen Liang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-12609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16195395#comment-16195395 ] 

Chen Liang commented on HDFS-12609:
-----------------------------------

Thanks [~nandakumar131] for working on this! v000 patch looks pretty good to me, just two minor comments:
1. TestNodeManager's below comment still says clear the flag
{code}
// Make sure that once we clear the manual chill mode flag
{code}

2. SCMNodeManager
Original forceEnterChillMode logs a message. I think we should keep it, and also log a message when calling exitChillMode

> Ozone: SCM: Refactoring of chill mode logic in NodeManager
> ----------------------------------------------------------
>
>                 Key: HDFS-12609
>                 URL: https://issues.apache.org/jira/browse/HDFS-12609
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: ozone
>            Reporter: Nandakumar
>            Assignee: Nandakumar
>         Attachments: HDFS-12609-HDFS-7240.000.patch
>
>
> As per the discussion in HDFS-12467, this jira is for refactoring chill mode logic in SCM's {{NodeManager}}.
> The following methods will be supported to manipulate chill mode status of SCM
> * {{forceExitChillMode}} - will bring SCM out of chill mode (both startup and manual)
> * {{enterChillMode}} - will set manual chill mode flag to true
> * {{exitChillMode}} - will set manual chill mode flag to false
> * {{getChillModeStatus}} - will return chill mode status string
> * {{isOutOfChillMode}} - will return true if SCM is out of chill mode, else false



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org