You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/04/22 06:43:34 UTC
[GitHub] [james-project] chibenwa opened a new pull request #399: JAMES-3261 Package memory docker images with JIB
chibenwa opened a new pull request #399:
URL: https://github.com/apache/james-project/pull/399
I took time to port what we have regarding James packaging with James. Includes:
- The CLI. Strategy is to add a runtime dependency and have a custom script.
- Glowroot is bundled. Downloaded by a maven plugin, and combined with its configuration files before being added to the image.
- extra java options are supported via an environment variable
Let's review this one first, then I devote myself committing this for the other guice servers.
The image size is slightly bigger (573 MB vs 383MB for the 3.6.0 memory docker image), it might be worth it to investigate where the extra size is coming from.
I choose buildTar as a goal, but in the end dockerBuild goal might enable us to run tests on top of the James docker images (what we used to call 'deployment tests' to check image validity, as testing dependencies could (had) been hiding problems). Not docker users could then use `-Djib.skip` to not be impacted by this possible choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #399: JAMES-3261 Package memory docker images with JIB
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #399:
URL: https://github.com/apache/james-project/pull/399#issuecomment-842848074
Rebased so that I can merge this - I'll wait the merge result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #399: JAMES-3261 Package memory docker images with JIB
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #399:
URL: https://github.com/apache/james-project/pull/399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #399: JAMES-3261 Package memory docker images with JIB
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #399:
URL: https://github.com/apache/james-project/pull/399#issuecomment-831664244
We are not in a hurry.
Let's give a chance for people to play with the new packaging and propose enhancements.
Let's wait to see if further reviews could be attempted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #399: JAMES-3261 Package memory docker images with JIB
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #399:
URL: https://github.com/apache/james-project/pull/399#issuecomment-828948278
I removed the no review commits...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #399: JAMES-3261 Package memory docker images with JIB
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #399:
URL: https://github.com/apache/james-project/pull/399#issuecomment-837827253
I will likely implement JIB stuff for other servers this weekend.
If by then there is no other suggestions/remarks, I will merge this work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org