You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Philip Zeyliger (Code Review)" <ge...@cloudera.org> on 2018/07/06 21:47:41 UTC

[Impala-ASF-CR] IMPALA-7199: Add scripts to create code coverage reports

Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10791 )

Change subject: IMPALA-7199: Add scripts to create code coverage reports
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10791/2/bin/coverage_helper.sh
File bin/coverage_helper.sh:

http://gerrit.cloudera.org:8080/#/c/10791/2/bin/coverage_helper.sh@44
PS2, Line 44:        shift;
is that semicolon doing anything?


http://gerrit.cloudera.org:8080/#/c/10791/2/bin/coverage_helper.sh@51
PS2, Line 51:   shift;
I don't think that semicolon needs to be tehre?



-- 
To view, visit http://gerrit.cloudera.org:8080/10791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b2e0b794c64f9343ec976de7a3f235e54d2badd
Gerrit-Change-Number: 10791
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jul 2018 21:47:41 +0000
Gerrit-HasComments: Yes