You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/12/21 20:35:06 UTC
[Impala-ASF-CR] IMPALA-9966: Add missing breaks in SetQueryOption
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16892
Change subject: IMPALA-9966: Add missing breaks in SetQueryOption
......................................................................
IMPALA-9966: Add missing breaks in SetQueryOption
Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d
---
M be/src/service/query-options.cc
1 file changed, 7 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/16892/1
--
To view, visit http://gerrit.cloudera.org:8080/16892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d
Gerrit-Change-Number: 16892
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9966: Add missing breaks in SetQueryOption
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16892 )
Change subject: IMPALA-9966: Add missing breaks in SetQueryOption
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d
Gerrit-Change-Number: 16892
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Dec 2020 04:31:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9966: Add missing breaks in SetQueryOption
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16892 )
Change subject: IMPALA-9966: Add missing breaks in SetQueryOption
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/7890/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d
Gerrit-Change-Number: 16892
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Dec 2020 20:57:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9966: Add missing breaks in SetQueryOption
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16892 )
Change subject: IMPALA-9966: Add missing breaks in SetQueryOption
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6798/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d
Gerrit-Change-Number: 16892
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Dec 2020 22:50:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9966: Add missing breaks in SetQueryOption
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16892 )
Change subject: IMPALA-9966: Add missing breaks in SetQueryOption
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d
Gerrit-Change-Number: 16892
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Dec 2020 22:50:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9966: Add missing breaks in SetQueryOption
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16892 )
Change subject: IMPALA-9966: Add missing breaks in SetQueryOption
......................................................................
IMPALA-9966: Add missing breaks in SetQueryOption
Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d
Reviewed-on: http://gerrit.cloudera.org:8080/16892
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/query-options.cc
1 file changed, 7 insertions(+), 5 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d
Gerrit-Change-Number: 16892
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9966: Add missing breaks in SetQueryOption
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16892 )
Change subject: IMPALA-9966: Add missing breaks in SetQueryOption
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16892
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I696204c7036c0059fe4eed2d23c8e947b6c53d8d
Gerrit-Change-Number: 16892
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 21 Dec 2020 22:49:17 +0000
Gerrit-HasComments: No