[GitHub] [incubator-kvrocks] ShooterIT commented on issue #1001: Make kvrocks dump rdb file which redis can load.

[GitBox <gi...@apache.org>]

ShooterIT commented on issue #1001:
URL: https://github.com/apache/incubator-kvrocks/issues/1001#issuecomment-1304982649

   Hi @ColinChamber @git-hulk i don't think supporting dumping RDB in Kvrocks is a good idea.
   Kvrocks builds its data based on SSD, and its data volume usually is huge, so the RDB usually is big, i don't think it is a general requirement of loading so big RDB file into redis. What's more, Kvrocks is Kvrocks rather than a fork of redis, we support redis protocol and some commands, don't need to support everything, so i think it is not suitable to support dumping RDB in Kvrocks core code,  and now we already has `kvrocks2redis` which could generate AOF, i think it looks enough, even we want to support dumping rdb, we should implement this feature in `kvrocks2redis`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org