You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/01/16 05:10:26 UTC
Review Request 29958: Upgrade pack for Knox
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29958/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
Bugs: AMBARI-9169
https://issues.apache.org/jira/browse/AMBARI-9169
Repository: ambari
Description
-------
Create the upgrade pack and steps for upgrading Knox Servers.
Diffs
-----
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 9332bff
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 3c91992
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py debd77e
Diff: https://reviews.apache.org/r/29958/diff/
Testing
-------
Unit test added. All existing tests pass.
Manual testing is in progress...
Thanks,
Tom Beerbower
Re: Review Request 29958: Upgrade pack for Knox
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On Jan. 16, 2015, 2:37 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py, lines 38-40
> > <https://reviews.apache.org/r/29958/diff/1/?file=823366#file823366line38>
> >
> > Does Knox have a /usr/hdp/current/knox-client directory like many of the other services do? If so, we probably need to determine which directory to use based on the command. If not, then disregard.
No /usr/hdp/current/knox-client directory that I can see. Only /usr/hdp/current/knox-server/.
> On Jan. 16, 2015, 2:37 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py, line 69
> > <https://reviews.apache.org/r/29958/diff/1/?file=823367#file823367line69>
> >
> > Is only the data directory needed in the backup? Some components also need the conf directory as well.
The example in the run book only shows data, but after reading it again I see "in case of some sort of corruption by the new runtime or added configuration after the upgrade." So, I guess that I should include conf as well.
Thanks for the review! ... and thanks for the backup code from Oozie!
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29958/#review68427
-----------------------------------------------------------
On Jan. 16, 2015, 4:10 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29958/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 4:10 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-9169
> https://issues.apache.org/jira/browse/AMBARI-9169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create the upgrade pack and steps for upgrading Knox Servers.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 9332bff
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 3c91992
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
> ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py debd77e
>
> Diff: https://reviews.apache.org/r/29958/diff/
>
>
> Testing
> -------
>
> Unit test added. All existing tests pass.
>
> Manual testing is in progress...
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 29958: Upgrade pack for Knox
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29958/#review68427
-----------------------------------------------------------
Ship it!
I noticed that you did a data back up but no restore. Just wanted to verify that's correct.
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py
<https://reviews.apache.org/r/29958/#comment112640>
Does Knox have a /usr/hdp/current/knox-client directory like many of the other services do? If so, we probably need to determine which directory to use based on the command. If not, then disregard.
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py
<https://reviews.apache.org/r/29958/#comment112641>
Is only the data directory needed in the backup? Some components also need the conf directory as well.
- Jonathan Hurley
On Jan. 15, 2015, 11:10 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29958/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2015, 11:10 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
>
>
> Bugs: AMBARI-9169
> https://issues.apache.org/jira/browse/AMBARI-9169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Create the upgrade pack and steps for upgrading Knox Servers.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 9332bff
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 3c91992
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
> ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py debd77e
>
> Diff: https://reviews.apache.org/r/29958/diff/
>
>
> Testing
> -------
>
> Unit test added. All existing tests pass.
>
> Manual testing is in progress...
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 29958: Upgrade pack for Knox
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29958/
-----------------------------------------------------------
(Updated Jan. 16, 2015, 3:18 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.
Changes
-------
Updated to include configuration in backup.
Completed manual testing.
Bugs: AMBARI-9169
https://issues.apache.org/jira/browse/AMBARI-9169
Repository: ambari
Description
-------
Create the upgrade pack and steps for upgrading Knox Servers.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py 9332bff
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params.py 3c91992
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.2.xml 15aa1f5
ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py debd77e
Diff: https://reviews.apache.org/r/29958/diff/
Testing (updated)
-------
Manual tested upgrade of Knox.
Unit test added. All existing tests pass.
Thanks,
Tom Beerbower