[jira] [Comment Edited] (HBASE-13387) Add ServerCell an extension to Cell

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393032#comment-14393032 ] 

Andrew Purtell edited comment on HBASE-13387 at 4/2/15 5:53 PM:
----------------------------------------------------------------

Meh.

hasArray() leads to separate code paths to deal with on-heap and off-heap differences so we litter code paths everywhere with double the logic. Why not push this down into specialized Cell implementations? So there should be no need for hasArray() exposed in interface, and no need for branching on hasArray() all over the place.


was (Author: apurtell):
Meh.

hasArray() and doubling the code paths to deal with on heap and off heap cell differences litters code paths everywhere with double the logic. Why not push this down into specialized Cell implementations? So there should be no need for hasArray() exposed in interface. 

> Add ServerCell an extension to Cell
> -----------------------------------
>
>                 Key: HBASE-13387
>                 URL: https://issues.apache.org/jira/browse/HBASE-13387
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>         Attachments: WIP_ServerCell.patch
>
>
> This came in btw the discussion abt the parent Jira and recently Stack added as a comment on the E2E patch on the parent Jira.
> The idea is to add a new Interface 'ServerCell'  in which we can add new buffer based getter APIs, hasArray API etc.  We will keep this interface @InterfaceAudience.Private
> Also we have to change the timestamp and seqId on Cells in server side. We have added new interfaces SettableSequenceId, SettableTimestamp for this. Now if we can add a ServerCell we can add the setter APIs there.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)