You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/27 06:28:04 UTC
[jira] [Commented] (BEAM-2074) SourceDStream's rate control
mechanism may not work
[ https://issues.apache.org/jira/browse/BEAM-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986090#comment-15986090 ]
ASF GitHub Bot commented on BEAM-2074:
--------------------------------------
GitHub user staslev opened a pull request:
https://github.com/apache/beam/pull/2733
[BEAM-2074,BEAM-2073] Fixed SourceDStream's rate control usage.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/staslev/beam BEAM-2074-2073-fix-SourceDStream-rate-control
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2733.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2733
----
commit 609a98a96ea9cc10c87f079872975b98baf62752
Author: Stas Levin <st...@apache.org>
Date: 2017-04-26T08:46:31Z
Fixed SourceDStream's rate control usage.
----
> SourceDStream's rate control mechanism may not work
> ---------------------------------------------------
>
> Key: BEAM-2074
> URL: https://issues.apache.org/jira/browse/BEAM-2074
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: Stas Levin
> Assignee: Stas Levin
>
> If the {{boundMaxRecords}} for {{SourceDStream}} is not set (as a result of users choosing not to specify {{SparkPipelineOptions.setMaxRecordsPerBatch()}}), {{SourceDStream}} is designed to use {{rateControlledMaxRecords()}} to determine the max number of records it should be reading.
> However, at the moment {{SourceDStream}} only consults {{rateControlledMaxRecords()}} once, when it is created, thus following
> instantiations of {{MicrobatchSource}} will be using the now-set-in-stone {{boundMaxRecords}} value without consulting with {{rateControlledMaxRecords()}}, making the rate controlling mechanism sub-optimal.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)