You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vivek Ratnavel Subramanian <vi...@gmail.com> on 2016/12/05 23:28:14 UTC
Re: Review Request 53969: When HS2Interactive is enabled,
any hive config change results in a CS queue refresh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53969/
-----------------------------------------------------------
(Updated Dec. 5, 2016, 11:28 p.m.)
Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
Changes
-------
Added changes to markup in popup modal dialog buttons to uniquely identify each button.
Verified manually. Ambari-web unit tests pass.
25633 tests complete (19 seconds)
57 tests pending
Bugs: AMBARI-18941
https://issues.apache.org/jira/browse/AMBARI-18941
Repository: ambari
Description
-------
Ambari keeps refreshing CS queues each time any config is changed in Hive - including Hive1 configs. The refresh should happen when the user actually changes the capacity scheduler slider.
Diffs (updated)
-----
ambari-web/app/controllers/main/service.js d6fbfbb
ambari-web/app/messages.js e8517b2
ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 9271675
ambari-web/app/models/configs/theme/config_action.js 70c1e99
ambari-web/app/templates/common/modal_popup.hbs 1d67a41
ambari-web/app/utils/ajax/ajax.js 0a6719b
ambari-web/app/utils/batch_scheduled_requests.js c9828a4
ambari-web/app/views/common/modal_popup.js 252604e
ambari-web/app/views/common/modal_popups/confirmation_popup.js fbcc882
ambari-web/test/controllers/main/service_test.js 440c26e
ambari-web/test/utils/batch_scheduled_requests_test.js 20b190b
Diff: https://reviews.apache.org/r/53969/diff/
Testing
-------
Verified Manually. Ambari-web unit tests pass.
25343 tests complete (19 seconds)
57 tests pending
Thanks,
Vivek Ratnavel Subramanian
Re: Review Request 53969: When HS2Interactive is enabled,
any hive config change results in a CS queue refresh
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53969/#review158400
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Dec. 5, 2016, 11:28 p.m., Vivek Ratnavel Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53969/
> -----------------------------------------------------------
>
> (Updated Dec. 5, 2016, 11:28 p.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-18941
> https://issues.apache.org/jira/browse/AMBARI-18941
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari keeps refreshing CS queues each time any config is changed in Hive - including Hive1 configs. The refresh should happen when the user actually changes the capacity scheduler slider.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service.js d6fbfbb
> ambari-web/app/messages.js e8517b2
> ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 9271675
> ambari-web/app/models/configs/theme/config_action.js 70c1e99
> ambari-web/app/templates/common/modal_popup.hbs 1d67a41
> ambari-web/app/utils/ajax/ajax.js 0a6719b
> ambari-web/app/utils/batch_scheduled_requests.js c9828a4
> ambari-web/app/views/common/modal_popup.js 252604e
> ambari-web/app/views/common/modal_popups/confirmation_popup.js fbcc882
> ambari-web/test/controllers/main/service_test.js 440c26e
> ambari-web/test/utils/batch_scheduled_requests_test.js 20b190b
>
> Diff: https://reviews.apache.org/r/53969/diff/
>
>
> Testing
> -------
>
> Verified Manually. Ambari-web unit tests pass.
>
> 25343 tests complete (19 seconds)
> 57 tests pending
>
>
> Thanks,
>
> Vivek Ratnavel Subramanian
>
>