You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/01/21 00:23:17 UTC
Re: Review Request 55772: Rejected optimizing if we are working with a
libcxx with UB.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55772/
-----------------------------------------------------------
(Updated Jan. 21, 2017, 1:23 a.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Turned warning into error.
Summary (updated)
-----------------
Rejected optimizing if we are working with a libcxx with UB.
Bugs: MESOS-6606
https://issues.apache.org/jira/browse/MESOS-6606
Repository: mesos
Description (updated)
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 48e3b14e3a70e8b0dc416c35997e8784d3409772
Diff: https://reviews.apache.org/r/55772/diff/
Testing
-------
Tested on OS X Sierra with both bundled clang+stdlib and versions close to their HEADs with
$ autoreconf -fi && ./configure CXX=/usr/bin/clang++
$ autoreconf -fi && ./configure CXX=clang++ # versions from HEAD
$ autoreconf -fi && ./configure --enable-optimize CXX=/usr/bin/clang++
$ autoreconf -fi && ./configure --enable-optimize CXX=clang++ # versions from HEAD
Thanks,
Benjamin Bannier
Re: Review Request 55772: Rejected optimizing if we are working with a
libcxx with UB.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55772/#review162801
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Jan. 23, 2017, 11:32 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55772/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2017, 11:32 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-6606
> https://issues.apache.org/jira/browse/MESOS-6606
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 48e3b14e3a70e8b0dc416c35997e8784d3409772
>
> Diff: https://reviews.apache.org/r/55772/diff/
>
>
> Testing
> -------
>
> Tested on OS X Sierra with both bundled clang+stdlib and versions close to their HEADs with
>
> $ autoreconf -fi && ./configure CXX=/usr/bin/clang++
> $ autoreconf -fi && ./configure CXX=clang++ # versions from HEAD
>
> $ autoreconf -fi && ./configure --enable-optimize CXX=/usr/bin/clang++
> $ autoreconf -fi && ./configure --enable-optimize CXX=clang++ # versions from HEAD
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 55772: Rejected optimizing if we are working with a
libcxx with UB.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55772/
-----------------------------------------------------------
(Updated Feb. 8, 2017, 7:55 a.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Rebased.
Bugs: MESOS-6606
https://issues.apache.org/jira/browse/MESOS-6606
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 48e3b14e3a70e8b0dc416c35997e8784d3409772
Diff: https://reviews.apache.org/r/55772/diff/
Testing
-------
Tested on OS X Sierra with both bundled clang+stdlib and versions close to their HEADs with
$ autoreconf -fi && ./configure CXX=/usr/bin/clang++
$ autoreconf -fi && ./configure CXX=clang++ # versions from HEAD
$ autoreconf -fi && ./configure --enable-optimize CXX=/usr/bin/clang++
$ autoreconf -fi && ./configure --enable-optimize CXX=clang++ # versions from HEAD
Thanks,
Benjamin Bannier
Re: Review Request 55772: Rejected optimizing if we are working with a
libcxx with UB.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55772/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 8:49 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Used idiomatic way to output progress.
Bugs: MESOS-6606
https://issues.apache.org/jira/browse/MESOS-6606
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 48e3b14e3a70e8b0dc416c35997e8784d3409772
Diff: https://reviews.apache.org/r/55772/diff/
Testing
-------
Tested on OS X Sierra with both bundled clang+stdlib and versions close to their HEADs with
$ autoreconf -fi && ./configure CXX=/usr/bin/clang++
$ autoreconf -fi && ./configure CXX=clang++ # versions from HEAD
$ autoreconf -fi && ./configure --enable-optimize CXX=/usr/bin/clang++
$ autoreconf -fi && ./configure --enable-optimize CXX=clang++ # versions from HEAD
Thanks,
Benjamin Bannier
Re: Review Request 55772: Rejected optimizing if we are working with a
libcxx with UB.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55772/
-----------------------------------------------------------
(Updated Jan. 23, 2017, 12:32 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Make whitespace more awesome.
Bugs: MESOS-6606
https://issues.apache.org/jira/browse/MESOS-6606
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 48e3b14e3a70e8b0dc416c35997e8784d3409772
Diff: https://reviews.apache.org/r/55772/diff/
Testing
-------
Tested on OS X Sierra with both bundled clang+stdlib and versions close to their HEADs with
$ autoreconf -fi && ./configure CXX=/usr/bin/clang++
$ autoreconf -fi && ./configure CXX=clang++ # versions from HEAD
$ autoreconf -fi && ./configure --enable-optimize CXX=/usr/bin/clang++
$ autoreconf -fi && ./configure --enable-optimize CXX=clang++ # versions from HEAD
Thanks,
Benjamin Bannier