You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Matt Sergeant <ma...@sergeant.org> on 2001/12/30 15:52:43 UTC
Apache::Test on 5.00503
Is Apache::Test intended to run on 5.00503? If so, then t/apache/limits.t
doesn't compile there (use warnings, and line 64). Otherwise, you should
add a use 5.006 line or something to the Makefile.PL.
RCS file: /home/cvspublic/httpd-test/perl-framework/t/apache/limits.t,v
retrieving revision 1.10
diff -u -r1.10 limits.t
--- t/apache/limits.t 20 Dec 2001 04:22:45 -0000 1.10
+++ t/apache/limits.t 30 Dec 2001 14:51:51 -0000
@@ -3,7 +3,7 @@
# and LimitRequestBody directives.
#
use strict;
-use warnings FATAL => 'all';
+# use warnings FATAL => 'all';
use Apache::Test;
use Apache::TestRequest;
@@ -61,7 +61,7 @@
my $testnum = 1;
foreach my $cond (@conditions) {
- foreach my $goodbad qw(succeed fail) {
+ foreach my $goodbad (qw(succeed fail)) {
my $param = $params{"$cond-$goodbad"};
my $expected_rc = $xrcs{"$cond-$goodbad"};
my $resp;
--
<!-- Matt -->
<:->Get a smart net</:->
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: make test TEST_VERBOSE=1 TEST_FILES=t/*.t
Posted by Stas Bekman <st...@stason.org>.
Matt Sergeant wrote:
> On Mon, 31 Dec 2001, Stas Bekman wrote:
>>>Sorry, I guess I wasn't clear. Those are make variables you can set on the
>>>call to make test. Check a Makefile generated (but one that uses the
>>>standard test suite, not Apache::Test).
>>
>>You want to be able to say:
>>
>> % make test TEST_VERBOSE=1 TEST_FILES=t/*.t
Hmm, looks like 31 Dec 2001 was a long time ago, but your wish is now granted,
thanks to Geoff's reminding ;) It's in cvs now, give it a test.
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: make test TEST_VERBOSE=1 TEST_FILES=t/*.t
Posted by Matt Sergeant <ma...@sergeant.org>.
On Mon, 31 Dec 2001, Stas Bekman wrote:
> [subject change to reflect the real topic]
>
> Matt Sergeant wrote:
>
>
> > Sorry, I guess I wasn't clear. Those are make variables you can set on the
> > call to make test. Check a Makefile generated (but one that uses the
> > standard test suite, not Apache::Test).
>
> You want to be able to say:
>
> % make test TEST_VERBOSE=1 TEST_FILES=t/*.t
>
> ?
>
> is this OK? :
Should be. I'll test it a bit later today.
--
<!-- Matt -->
<:->Get a smart net</:->
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: make test TEST_VERBOSE=1 TEST_FILES=t/*.t
Posted by Doug MacEachern <do...@covalent.net>.
On Mon, 7 Jan 2002, Stas Bekman wrote:
> That's from the gnu make manpages. What's the syntax that works in all
> makefiles?
there isn't a conditional syntax that works in all makefiles.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: make test TEST_VERBOSE=1 TEST_FILES=t/*.t
Posted by Stas Bekman <st...@stason.org>.
Doug MacEachern wrote:
> On Mon, 31 Dec 2001, Stas Bekman wrote:
>
>
>>+ifeq ($(TEST_VERBOSE), 1)
>>
>
> pretty sure that (ifeq) is a gmake-ism that won't work with vanilla make
> (like the standard ones on solaris, hpux, etc.)
That's from the gnu make manpages. What's the syntax that works in all
makefiles?
> maybe just make the t/TEST opts parser support TEST_VERBOSE=1 and the
> like?
I guess we can, but if we can make it on the make level, that's better,
IMHO.
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:stas@stason.org http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: make test TEST_VERBOSE=1 TEST_FILES=t/*.t
Posted by Doug MacEachern <do...@covalent.net>.
On Mon, 31 Dec 2001, Stas Bekman wrote:
> +ifeq ($(TEST_VERBOSE), 1)
pretty sure that (ifeq) is a gmake-ism that won't work with vanilla make
(like the standard ones on solaris, hpux, etc.)
maybe just make the t/TEST opts parser support TEST_VERBOSE=1 and the
like?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
make test TEST_VERBOSE=1 TEST_FILES=t/*.t
Posted by Stas Bekman <st...@stason.org>.
[subject change to reflect the real topic]
Matt Sergeant wrote:
> Sorry, I guess I wasn't clear. Those are make variables you can set on the
> call to make test. Check a Makefile generated (but one that uses the
> standard test suite, not Apache::Test).
You want to be able to say:
% make test TEST_VERBOSE=1 TEST_FILES=t/*.t
?
is this OK? :
Index: Apache-Test/lib/Apache/TestMM.pm
===================================================================
RCS file:
/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestMM.pm,vretrieving
revision 1.15
diff -u -r1.15 TestMM.pm
--- Apache-Test/lib/Apache/TestMM.pm 23 Dec 2001 16:16:24 -0000 1.15
+++ Apache-Test/lib/Apache/TestMM.pm 31 Dec 2001 09:38:52 -0000
@@ -43,14 +43,19 @@
EOF
return $preamble . <<'EOF';
+
+ifeq ($(TEST_VERBOSE), 1)
+ TEST_VERBOSE_OPT = -verbose
+endif
+
test_clean :
$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
t/TEST -clean
-
+
run_tests : test_clean
$(PASSENV) \
$(FULLPERL) -I$(INST_ARCHLIB) -I$(INST_LIB) \
-
t/TEST
+
t/TEST $(TEST_VERBOSE_OPT) $(TEST_FILES)
test :: pure_all run_tests test_clean
(hope this one wasn't mangled)
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:stas@stason.org http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::Test on 5.00503
Posted by Matt Sergeant <ma...@sergeant.org>.
On Mon, 31 Dec 2001, Stas Bekman wrote:
> Matt Sergeant wrote:
>
>
> > Another request - could we make Apache::Test obey the two Test::Harness
> > flags TEST_VERBOSE and TEST_FILES. This would make life so much easier.
>
> None of these seem to exist in the latest Test::Harness, I think these
> were undocumented features, so they are just gone. I'm looking at
> Test::Harness from bleadperl 5.7.2
>
> # $Id: Harness.pm,v 1.17 2001/09/07 06:20:29 schwern Exp $
>
> I see the same in:
> # $Id: Harness.pm,v 1.14.2.11 2001/12/18 03:17:48 schwern Exp $
>
> What you have is:
>
> =item B<$Test::Harness::verbose>
>
> The global variable $Test::Harness::verbose is exportable and can be
> used to let runtests() display the standard output of the script
> without altering the behavior otherwise.
Sorry, I guess I wasn't clear. Those are make variables you can set on the
call to make test. Check a Makefile generated (but one that uses the
standard test suite, not Apache::Test).
--
<!-- Matt -->
<:->Get a smart net</:->
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::Test on 5.00503
Posted by Stas Bekman <st...@stason.org>.
Matt Sergeant wrote:
> Another request - could we make Apache::Test obey the two Test::Harness
> flags TEST_VERBOSE and TEST_FILES. This would make life so much easier.
None of these seem to exist in the latest Test::Harness, I think these
were undocumented features, so they are just gone. I'm looking at
Test::Harness from bleadperl 5.7.2
# $Id: Harness.pm,v 1.17 2001/09/07 06:20:29 schwern Exp $
I see the same in:
# $Id: Harness.pm,v 1.14.2.11 2001/12/18 03:17:48 schwern Exp $
What you have is:
=item B<$Test::Harness::verbose>
The global variable $Test::Harness::verbose is exportable and can be
used to let runtests() display the standard output of the script
without altering the behavior otherwise.
_____________________________________________________________________
Stas Bekman JAm_pH -- Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide http://perl.apache.org/guide
mailto:stas@stason.org http://ticketmaster.com http://apacheweek.com
http://singlesheaven.com http://perl.apache.org http://perlmonth.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: Apache::Test on 5.00503
Posted by Matt Sergeant <ma...@sergeant.org>.
On Sun, 30 Dec 2001, Matt Sergeant wrote:
> Is Apache::Test intended to run on 5.00503? If so, then t/apache/limits.t
> doesn't compile there (use warnings, and line 64). Otherwise, you should
> add a use 5.006 line or something to the Makefile.PL.
>
> RCS file: /home/cvspublic/httpd-test/perl-framework/t/apache/limits.t,v
> retrieving revision 1.10
> diff -u -r1.10 limits.t
> --- t/apache/limits.t 20 Dec 2001 04:22:45 -0000 1.10
> +++ t/apache/limits.t 30 Dec 2001 14:51:51 -0000
> @@ -3,7 +3,7 @@
> # and LimitRequestBody directives.
> #
> use strict;
> -use warnings FATAL => 'all';
> +# use warnings FATAL => 'all';
Oops, forget this one. I just found the warnings.pm in the distro :-)
Another request - could we make Apache::Test obey the two Test::Harness
flags TEST_VERBOSE and TEST_FILES. This would make life so much easier.
Thanks!
--
<!-- Matt -->
<:->Get a smart net</:->
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org