You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/20 13:19:11 UTC

[GitHub] [arrow] zeroshade commented on a change in pull request #10106: ARROW-5640: [Go] Implement Arrow Map Array

zeroshade commented on a change in pull request #10106:
URL: https://github.com/apache/arrow/pull/10106#discussion_r616674653



##########
File path: go/arrow/array/builder.go
##########
@@ -277,6 +277,8 @@ func NewBuilder(mem memory.Allocator, dtype arrow.DataType) Builder {
 	case arrow.UNION:
 	case arrow.DICTIONARY:
 	case arrow.MAP:
+		typ := dtype.(*arrow.MapType)

Review comment:
       you're still thinking in C++ context. Go doesn't automatically fallthrough like C++, this *only* modifies the Map case, it doesn't change anything about Union or Dictionary.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org