You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by ah...@apache.org on 2017/04/06 11:00:45 UTC
zeppelin git commit: [ZEPPELIN-2304] Fix vis Icon sizes in helium
page (branch-0.7)
Repository: zeppelin
Updated Branches:
refs/heads/branch-0.7 78804bb78 -> af9a689eb
[ZEPPELIN-2304] Fix vis Icon sizes in helium page (branch-0.7)
### What is this PR for?
Icon size of helium vis packages doesn't fit into the container button. I attached a image.
### What type of PR is it?
[Bug Fix]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2304](https://issues.apache.org/jira/browse/ZEPPELIN-2304)
### How should this be tested?
1. Install 2+ vis packages.
2. Open the `#helium` page
### Screenshots (if appropriate)
#### Before
<img width="378" alt="2304_before" src="https://cloud.githubusercontent.com/assets/4968473/24238569/17b7dbaa-0fee-11e7-9994-39fd7700c70c.png">
#### After
<img width="389" alt="2304_after" src="https://cloud.githubusercontent.com/assets/4968473/24238572/1aac7b72-0fee-11e7-934d-da4c2d864b54.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
Author: 1ambda <1a...@gmail.com>
Closes #2224 from 1ambda/ZEPPELIN-2304/fix-vis-icon-size-in-helium-page-for-072 and squashes the following commits:
9853730 [1ambda] fix: Vis icon size in helium.html
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/af9a689e
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/af9a689e
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/af9a689e
Branch: refs/heads/branch-0.7
Commit: af9a689eb611013670e29e5da6b6fc1e37a801cd
Parents: 78804bb
Author: 1ambda <1a...@gmail.com>
Authored: Wed Apr 5 16:38:41 2017 +0900
Committer: ahyoungryu <ah...@apache.org>
Committed: Thu Apr 6 20:00:40 2017 +0900
----------------------------------------------------------------------
zeppelin-web/src/app/helium/helium.css | 6 ++++++
zeppelin-web/src/app/helium/helium.html | 4 ++--
2 files changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/af9a689e/zeppelin-web/src/app/helium/helium.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/helium/helium.css b/zeppelin-web/src/app/helium/helium.css
index 1d1a056..6040737 100644
--- a/zeppelin-web/src/app/helium/helium.css
+++ b/zeppelin-web/src/app/helium/helium.css
@@ -131,3 +131,9 @@
.gray40-message a:focus {
text-decoration: none;
}
+
+.heliumVisIconButton > img {
+ display: block;
+ max-width: 100%;
+ height: auto;
+}
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/af9a689e/zeppelin-web/src/app/helium/helium.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/helium/helium.html b/zeppelin-web/src/app/helium/helium.html
index 16da087..39d20c4 100644
--- a/zeppelin-web/src/app/helium/helium.html
+++ b/zeppelin-web/src/app/helium/helium.html
@@ -38,10 +38,10 @@ limitations under the License.
data-ng-model="visualizationOrder">
<div class="btn-group" data-ng-repeat="pkgName in visualizationOrder"
as-sortable-item>
- <div class="btn btn-default btn-sm"
+ <button class="btn btn-default btn-sm heliumVisIconButton"
ng-bind-html='defaultVersions[pkgName].pkg.icon'
as-sortable-item-handle>
- </div>
+ </button>
</div>
</div>
<div class="saveLink"