You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@creadur.apache.org by "P. Ottlinger" <po...@apache.org> on 2015/09/27 19:56:54 UTC
Re: Build failed in Jenkins: Creadur-Rat #290 / RAT-208
Hi *,
Am 27.09.2015 um 17:03 schrieb Apache Jenkins Server:
> See <https://builds.apache.org/job/Creadur-Rat/290/changes>
>
> Changes:
>
> [jochen] PR: RAT-208
>
> Added includesFile, excludesFile, includesFileCharacterset, and excludesFileCharacterset parameters,
> and support thereof.
Do we really need this parameter? I'd assume the exclude/include-File to
have the same encoding as the environment in which RAT runs.
At the moment we have lots of encoding leaks, thus I'd not want to add
explicit parameters to each possibility of different encodings ....
AFAIK we never used the changes.xml but only added new features to the
RELEASE_NOTES.txt file ....
Apart from that I think that AbstractRatMojo should not contain a method
to parse files .... if I'm not too mistaken I used the same
functionality to parse gitignore files - there must be a utility class
somewhere :-)
Cheers,
Phil
Re: Build failed in Jenkins: Creadur-Rat #290 / RAT-208 / usage of changes.xml
Posted by sebb <se...@gmail.com>.
On 28 September 2015 at 20:00, P. Ottlinger <po...@apache.org> wrote:
> Hi *,
>
> Am 28.09.2015 um 20:29 schrieb sebb:
>> It can be used to create the changes list on the website as well as
>> RELEASE_NOTES.
>>
>> It is how Commons does it.
>
> I'm in favour of the changes plugin as well, but how and where do we
> integrate the changes of the last releases?
>
>
> The changes.xml were not touched for a while:
>
> * https://svn.apache.org/repos/asf/creadur/rat/trunk/src/changes/changes.xml
> Last change: 2012-10-19 21:10:33 +0200
>
> *
> https://svn.apache.org/repos/asf/creadur/rat/trunk/apache-rat-plugin/src/changes/changes.xml
> Last change (before Jochens recent commit): 2012-10-19 21:10:33 +0200
>
> Maybe we should start improving on that after 0.12 is out of the door.
In which case it will probably be left until 0.14 ... etc.
I suggest at least putting the changes for 0.12 in the file and using
that for the RN.
We can add dummy entries (TBA) for the missing versions for now. I can do that.
At least then we would not be any worse off.
> Cheers,
> Phil
Re: Build failed in Jenkins: Creadur-Rat #290 / RAT-208 / usage of
changes.xml
Posted by "P. Ottlinger" <po...@apache.org>.
Hi *,
Am 28.09.2015 um 20:29 schrieb sebb:
> It can be used to create the changes list on the website as well as
> RELEASE_NOTES.
>
> It is how Commons does it.
I'm in favour of the changes plugin as well, but how and where do we
integrate the changes of the last releases?
The changes.xml were not touched for a while:
* https://svn.apache.org/repos/asf/creadur/rat/trunk/src/changes/changes.xml
Last change: 2012-10-19 21:10:33 +0200
*
https://svn.apache.org/repos/asf/creadur/rat/trunk/apache-rat-plugin/src/changes/changes.xml
Last change (before Jochens recent commit): 2012-10-19 21:10:33 +0200
Maybe we should start improving on that after 0.12 is out of the door.
Cheers,
Phil
Re: Build failed in Jenkins: Creadur-Rat #290 / RAT-208
Posted by sebb <se...@gmail.com>.
On 28 September 2015 at 15:23, Jochen Wiedmann
<jo...@gmail.com> wrote:
> On Sun, Sep 27, 2015 at 7:56 PM, P. Ottlinger <po...@apache.org> wrote:
>
>>> Added includesFile, excludesFile, includesFileCharacterset, and excludesFileCharacterset parameters,
>>> and support thereof.
>>
>>
>> Do we really need this parameter? I'd assume the exclude/include-File to
>> have the same encoding as the environment in which RAT runs.
>
>
> I felt like adding them now rather than triggering questions later.
> Note, that you don't need to use them explicitly, because the default
> is $project.build.sourceEncoding, which would exactly match your
> suggestion.
>
>
>> AFAIK we never used the changes.xml but only added new features to the
>> RELEASE_NOTES.txt file ....
>
> I may have missed something here. When I was young, we used to use
> changes.xml, and I still prefer it, because it is handled by Maven
> automatically.
+1
It can be used to create the changes list on the website as well as
RELEASE_NOTES.
It is how Commons does it.
>
> Jochen
>
>
>
> --
> The next time you hear: "Don't reinvent the wheel!"
>
> http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg
Re: Build failed in Jenkins: Creadur-Rat #290 / RAT-208
Posted by Jochen Wiedmann <jo...@gmail.com>.
On Sun, Sep 27, 2015 at 7:56 PM, P. Ottlinger <po...@apache.org> wrote:
>> Added includesFile, excludesFile, includesFileCharacterset, and excludesFileCharacterset parameters,
>> and support thereof.
>
>
> Do we really need this parameter? I'd assume the exclude/include-File to
> have the same encoding as the environment in which RAT runs.
I felt like adding them now rather than triggering questions later.
Note, that you don't need to use them explicitly, because the default
is $project.build.sourceEncoding, which would exactly match your
suggestion.
> AFAIK we never used the changes.xml but only added new features to the
> RELEASE_NOTES.txt file ....
I may have missed something here. When I was young, we used to use
changes.xml, and I still prefer it, because it is handled by Maven
automatically.
Jochen
--
The next time you hear: "Don't reinvent the wheel!"
http://www.keystonedevelopment.co.uk/wp-content/uploads/2014/10/evolution-of-the-wheel-300x85.jpg