[jira] [Commented] (YARN-447) applicationComparator improvement for CS

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13618701#comment-13618701 ] 

Hadoop QA commented on YARN-447:
--------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12576347/YARN-447-trunk.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 2 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/635//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/635//console

This message is automatically generated.
                
> applicationComparator improvement for CS
> ----------------------------------------
>
>                 Key: YARN-447
>                 URL: https://issues.apache.org/jira/browse/YARN-447
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.0.3-alpha
>            Reporter: nemon lou
>            Assignee: nemon lou
>            Priority: Minor
>         Attachments: YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch, YARN-447-trunk.patch
>
>
> Now the compare code is :
> return a1.getApplicationId().getId() - a2.getApplicationId().getId();
> Will be replaced with :
> return a1.getApplicationId().compareTo(a2.getApplicationId());
> This will bring some benefits:
> 1,leave applicationId compare logic to ApplicationId class;
> 2,In future's HA mode,cluster time stamp may change,ApplicationId class already takes care of this condition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira