[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4300: [KYUUBI #4282] Fix ConcurrentModificationException when log4j2 async enabled

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #4300:
URL: https://github.com/apache/kyuubi/pull/4300#discussion_r1102289919


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/operation/log/OperationLog.scala:
##########
@@ -34,17 +34,13 @@ import org.apache.kyuubi.session.Session
 import org.apache.kyuubi.util.ThriftUtils
 
 object OperationLog extends Logging {
-  final private val OPERATION_LOG: InheritableThreadLocal[OperationLog] = {
-    new InheritableThreadLocal[OperationLog] {
-      override def initialValue(): OperationLog = null
-    }
-  }
+  final private val OPERATION_LOG = new ThreadLocal[OperationLog]

Review Comment:
   I suppose it's not necessary to use `InheritableThreadLocal` here, am I missing something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org