You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/09/04 14:54:08 UTC
Review Request 62067: CLI: Added 'mesos container list' command.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/
-----------------------------------------------------------
Review request for mesos and Kevin Klues.
Bugs: MESOS-7285
https://issues.apache.org/jira/browse/MESOS-7285
Repository: mesos
Description
-------
This command displays the containers running
on all the agents or a specific one.
Diffs
-----
src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION
src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION
src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
src/python/cli_new/lib/cli/tests/container.py PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/62067/diff/1/
Testing
-------
To test with one master:
$ ./bootstrap
$ source activate
$ mesos-cli-tests
To test the command in High-Availability Mode I have:
1. Started ZooKeeper.
2. Started two masters using the flags --zk and --quorum.
3. Started one agent.
4. Launched one task using ./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'.
5. Checked that the output of 'mesos container list' was correct.
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 62067: CLI: Added 'mesos container list' command.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/#review186257
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62573.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62573`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62067
Relevant logs:
- [apply-review-62573-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62067/logs/apply-review-62573-stdout.log):
```
error: patch failed: src/python/cli_new/lib/cli/util.py:185
error: src/python/cli_new/lib/cli/util.py: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 4, 2017, 2:54 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62067/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 2:54 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7285
> https://issues.apache.org/jira/browse/MESOS-7285
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the containers running
> on all the agents or a specific one.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/container.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62067/diff/2/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62067: Added 'mesos container list' command to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/#review186404
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 62573.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62573`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62067
Relevant logs:
- [apply-review-62573-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62067/logs/apply-review-62573-stdout.log):
```
error: patch failed: src/python/cli_new/lib/cli/util.py:25
error: src/python/cli_new/lib/cli/util.py: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 27, 2017, 12:39 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62067/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:39 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7285
> https://issues.apache.org/jira/browse/MESOS-7285
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the containers running
> on all the agents or a specific one.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/container.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62067/diff/3/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62067: Added 'mesos container list' command to CLI.
Posted by Kevin Klues <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/#review186401
-----------------------------------------------------------
I think we need to think a bit more about how we want to pass the agent id / address to this command. We want to make sure it works in a generalized Mesos setup (without being opinionated about the connectivity of agents in the cluster to the machine where the CLI is running). As it stands now, this implementation assumes we have direct access to the agents from the CLI and are able to hit their <ip:port> directly to access their API. Maybe a simple `--proxy` flag with the URL to proxy API calls through would be sufficient (with a default that can be set in the config). We will need to play around with this a bit more though before deciding.
- Kevin Klues
On Sept. 27, 2017, 12:39 p.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62067/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:39 p.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7285
> https://issues.apache.org/jira/browse/MESOS-7285
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the containers running
> on all the agents or a specific one.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/container.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62067/diff/3/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62067: Added 'mesos container list' command to CLI.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/
-----------------------------------------------------------
(Updated Sept. 27, 2017, 12:39 p.m.)
Review request for mesos and Kevin Klues.
Changes
-------
Improved code.
Bugs: MESOS-7285
https://issues.apache.org/jira/browse/MESOS-7285
Repository: mesos
Description
-------
This command displays the containers running
on all the agents or a specific one.
Diffs (updated)
-----
src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION
src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION
src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
src/python/cli_new/lib/cli/tests/container.py PRE-CREATION
src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
Diff: https://reviews.apache.org/r/62067/diff/3/
Changes: https://reviews.apache.org/r/62067/diff/2-3/
Testing
-------
To test with one master:
$ ./bootstrap
$ source activate
$ mesos-cli-tests
I also checked that the Python linter was still working.
Thanks,
Armand Grillet
Re: Review Request 62067: CLI: Added 'mesos container list' command.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/#review184514
-----------------------------------------------------------
Bad review!
Error:
Circular dependency detected for review 62067.Please fix the 'depends_on' field.
- Mesos Reviewbot Windows
On Sept. 4, 2017, 7:54 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62067/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 7:54 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7285
> https://issues.apache.org/jira/browse/MESOS-7285
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the containers running
> on all the agents or a specific one.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/container.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62067/diff/1/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
>
> To test the command in High-Availability Mode I have:
> 1. Started ZooKeeper.
> 2. Started two masters using the flags --zk and --quorum.
> 3. Started one agent.
> 4. Launched one task using ./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'.
> 5. Checked that the output of 'mesos container list' was correct.
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62067: Added 'mesos container list' command to CLI.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/#review186280
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 61212.
Failed command: `python.exe .\support\apply-reviews.py -n -r 61212`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62067
Relevant logs:
- [apply-review-61212-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62067/logs/apply-review-61212-stdout.log):
```
error: patch failed: src/python/cli_new/lib/cli/util.py:22
error: src/python/cli_new/lib/cli/util.py: patch does not apply
```
- Mesos Reviewbot Windows
On Sept. 4, 2017, 7:54 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62067/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 7:54 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7285
> https://issues.apache.org/jira/browse/MESOS-7285
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the containers running
> on all the agents or a specific one.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/container.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62067/diff/2/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>
Re: Review Request 62067: CLI: Added 'mesos container list' command.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62067/#review184498
-----------------------------------------------------------
Bad patch!
Reviews applied: [62067, 62066, 62065, 61212]
Failed command: python support/apply-reviews.py -n -r 62065
Error:
2017-09-04 17:02:37 URL:https://reviews.apache.org/r/62065/diff/raw/ [8658/8658] -> "62065.patch" [1]
error: patch failed: src/python/cli_new/bin/settings.py:38
error: src/python/cli_new/bin/settings.py: patch does not apply
error: patch failed: src/python/cli_new/lib/cli/tests/__init__.py:20
error: src/python/cli_new/lib/cli/tests/__init__.py: patch does not apply
error: patch failed: src/python/cli_new/tests/main.py:27
error: src/python/cli_new/tests/main.py: patch does not apply
Full log: https://builds.apache.org/job/Mesos-Reviewbot/19197/console
- Mesos Reviewbot
On Sept. 4, 2017, 10:54 a.m., Armand Grillet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62067/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 10:54 a.m.)
>
>
> Review request for mesos and Kevin Klues.
>
>
> Bugs: MESOS-7285
> https://issues.apache.org/jira/browse/MESOS-7285
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This command displays the containers running
> on all the agents or a specific one.
>
>
> Diffs
> -----
>
> src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0
> src/python/cli_new/lib/cli/plugins/container/__init__.py PRE-CREATION
> src/python/cli_new/lib/cli/plugins/container/main.py PRE-CREATION
> src/python/cli_new/lib/cli/tests/__init__.py 0daf28869e107263c51653ace39e3b1826871048
> src/python/cli_new/lib/cli/tests/container.py PRE-CREATION
> src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90
>
>
> Diff: https://reviews.apache.org/r/62067/diff/1/
>
>
> Testing
> -------
>
> To test with one master:
>
> $ ./bootstrap
> $ source activate
> $ mesos-cli-tests
>
>
> To test the command in High-Availability Mode I have:
> 1. Started ZooKeeper.
> 2. Started two masters using the flags --zk and --quorum.
> 3. Started one agent.
> 4. Launched one task using ./mesos-execute --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'.
> 5. Checked that the output of 'mesos container list' was correct.
>
> I also checked that the Python linter was still working.
>
>
> Thanks,
>
> Armand Grillet
>
>