You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "yamt (via GitHub)" <gi...@apache.org> on 2024/05/15 14:21:24 UTC
[PR] Add a few optional text heap APIs to support esp32s3 [nuttx]
yamt opened a new pull request, #12355:
URL: https://github.com/apache/nuttx/pull/12355
## Summary
esp32s3's Internal SRAM 1 and External Memory have two separate mappings for instructions and data.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a few optional text heap APIs to support esp32s3 [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12355:
URL: https://github.com/apache/nuttx/pull/12355#discussion_r1605670070
##########
arch/Kconfig:
##########
@@ -431,6 +431,18 @@ config ARCH_HAVE_TEXT_HEAP
---help---
Special memory region for dynamic code loading
+config ARCH_TEXT_HEAP_SEPARATE_DATA_ADDRESS
Review Comment:
yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a few optional text heap APIs to support esp32s3 [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #12355:
URL: https://github.com/apache/nuttx/pull/12355#discussion_r1604224913
##########
arch/Kconfig:
##########
@@ -431,6 +431,18 @@ config ARCH_HAVE_TEXT_HEAP
---help---
Special memory region for dynamic code loading
+config ARCH_TEXT_HEAP_SEPARATE_DATA_ADDRESS
Review Comment:
should we add HAVE_
##########
arch/Kconfig:
##########
@@ -431,6 +431,18 @@ config ARCH_HAVE_TEXT_HEAP
---help---
Special memory region for dynamic code loading
+config ARCH_TEXT_HEAP_SEPARATE_DATA_ADDRESS
+ bool
+ default n
+ ---help---
+ Textheap might have separate instruction/data mappings
+
+config ARCH_TEXT_HEAP_WORD_ALIGNED_READ
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a few optional text heap APIs to support esp32s3 [nuttx]
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on code in PR #12355:
URL: https://github.com/apache/nuttx/pull/12355#discussion_r1606230030
##########
arch/Kconfig:
##########
@@ -431,6 +431,18 @@ config ARCH_HAVE_TEXT_HEAP
---help---
Special memory region for dynamic code loading
+config ARCH_TEXT_HEAP_SEPARATE_DATA_ADDRESS
Review Comment:
do. renamed.
see also
https://github.com/apache/nuttx-apps/pull/2400
https://github.com/bytecodealliance/wasm-micro-runtime/pull/3449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a few optional text heap APIs to support esp32s3 [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #12355:
URL: https://github.com/apache/nuttx/pull/12355#issuecomment-2113305758
@tmedicci please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a few optional text heap APIs to support esp32s3 [nuttx]
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on code in PR #12355:
URL: https://github.com/apache/nuttx/pull/12355#discussion_r1606230030
##########
arch/Kconfig:
##########
@@ -431,6 +431,18 @@ config ARCH_HAVE_TEXT_HEAP
---help---
Special memory region for dynamic code loading
+config ARCH_TEXT_HEAP_SEPARATE_DATA_ADDRESS
Review Comment:
ok. renamed.
see also
https://github.com/apache/nuttx-apps/pull/2400
https://github.com/bytecodealliance/wasm-micro-runtime/pull/3449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a few optional text heap APIs to support esp32s3 [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #12355:
URL: https://github.com/apache/nuttx/pull/12355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add a few optional text heap APIs to support esp32s3 [nuttx]
Posted by "yamt (via GitHub)" <gi...@apache.org>.
yamt commented on code in PR #12355:
URL: https://github.com/apache/nuttx/pull/12355#discussion_r1604345272
##########
arch/Kconfig:
##########
@@ -431,6 +431,18 @@ config ARCH_HAVE_TEXT_HEAP
---help---
Special memory region for dynamic code loading
+config ARCH_TEXT_HEAP_SEPARATE_DATA_ADDRESS
Review Comment:
do you mean ARCH_HAVE_TEXT_HEAP_SEPARATE_DATA_ADDRESS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org