[GitHub] [incubator-superset] john-bodley commented on issue #7604: [SIP-22] Proposal for changes to time filter to allow for more flexible time range selections

[GitBox <gi...@apache.org>]

john-bodley commented on issue #7604:  [SIP-22] Proposal for changes to time filter to allow for more flexible time range selections
URL: https://github.com/apache/incubator-superset/issues/7604#issuecomment-497037835
 
 
   @vylc I think these changes make a lot of sense and touch on some aspects of SIP-15 regarding explicit callout. A few comments/thoughts: 
   
   1. It's also worth pointing out that the current relative timestamp sometimes uses _now_ and other times uses _today_ as the reference point which is somewhat confusing.
   
   2. Related to SIP-15 should we align on supporting dates and timestamps or just make everything timestamps? I proposed the former in SIP-15 but I'm not opposed to the later. Note there are other temporal grains; week, month, quarter, year etc. however we (and other BI tools) normally just encode these as timestamps.
   
   3. For `DAY` I'm not sure that  "Today so far (now)" should reference now as we're talking about dates and not times. I'm uncertain whether it should be `[, today)` (exclusive of today) or `[, tomorrow)` (inclusive of today). 
   
   4. We need to ensure that the time window is apparent when the widget is closed.
   
   5. From a UX perspective we're really specifying a time window either as: i) a start and and end, ii) a start with a duration, or iii) and end with a duration and was wondering whether there was merit in trying to design this into the widget somehow (which ties into #4).  
   
   6. We also have a time grain selector and wonder if it make sense to keep these decoupled or somehow combine them. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org