You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/09 05:49:43 UTC
[GitHub] [tvm] prateek9623 commented on a change in pull request #10097: [CMake] add support for find_package
prateek9623 commented on a change in pull request #10097:
URL: https://github.com/apache/tvm/pull/10097#discussion_r802287602
##########
File path: CMakeLists.txt
##########
@@ -620,33 +611,54 @@ endif()
add_custom_target(runtime DEPENDS tvm_runtime)
# Installation rules
-install(TARGETS tvm DESTINATION lib${LIB_SUFFIX})
-install(TARGETS tvm_runtime DESTINATION lib${LIB_SUFFIX})
+install(TARGETS tvm EXPORT ${PROJECT_NAME}Targets DESTINATION lib${LIB_SUFFIX})
+install(TARGETS tvm_runtime EXPORT ${PROJECT_NAME}Targets DESTINATION lib${LIB_SUFFIX})
if (INSTALL_DEV)
install(
- DIRECTORY "include/." DESTINATION "include"
+ DIRECTORY "include/" DESTINATION "include"
FILES_MATCHING
PATTERN "*.h"
)
install(
- DIRECTORY "3rdparty/dlpack/include/." DESTINATION "include"
+ DIRECTORY "3rdparty/dlpack/include/" DESTINATION "include"
FILES_MATCHING
PATTERN "*.h"
)
install(
- DIRECTORY "3rdparty/dmlc-core/include/." DESTINATION "include"
+ DIRECTORY "3rdparty/dmlc-core/include/" DESTINATION "include"
FILES_MATCHING
PATTERN "*.h"
)
else(INSTALL_DEV)
install(
- DIRECTORY "include/tvm/runtime/." DESTINATION "include/tvm/runtime"
+ DIRECTORY "include/tvm/runtime/" DESTINATION "include/tvm/runtime"
FILES_MATCHING
PATTERN "*.h"
)
endif(INSTALL_DEV)
+include(GNUInstallDirs)
+include(CMakePackageConfigHelpers)
+set(PROJECT_CONFIG_CONTENT "@PACKAGE_INIT@\n")
+string(APPEND PROJECT_CONFIG_CONTENT
+ "include(\"\${CMAKE_CURRENT_LIST_DIR}/${PROJECT_NAME}Targets.cmake\")")
+file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/PROJECT_CONFIG_FILE" ${PROJECT_CONFIG_CONTENT})
Review comment:
this to generate temp file, final file name will be "tvmConfig.cmake"
##########
File path: CMakeLists.txt
##########
@@ -620,33 +611,54 @@ endif()
add_custom_target(runtime DEPENDS tvm_runtime)
# Installation rules
-install(TARGETS tvm DESTINATION lib${LIB_SUFFIX})
-install(TARGETS tvm_runtime DESTINATION lib${LIB_SUFFIX})
+install(TARGETS tvm EXPORT ${PROJECT_NAME}Targets DESTINATION lib${LIB_SUFFIX})
+install(TARGETS tvm_runtime EXPORT ${PROJECT_NAME}Targets DESTINATION lib${LIB_SUFFIX})
if (INSTALL_DEV)
install(
- DIRECTORY "include/." DESTINATION "include"
+ DIRECTORY "include/" DESTINATION "include"
FILES_MATCHING
PATTERN "*.h"
)
install(
- DIRECTORY "3rdparty/dlpack/include/." DESTINATION "include"
+ DIRECTORY "3rdparty/dlpack/include/" DESTINATION "include"
FILES_MATCHING
PATTERN "*.h"
)
install(
- DIRECTORY "3rdparty/dmlc-core/include/." DESTINATION "include"
+ DIRECTORY "3rdparty/dmlc-core/include/" DESTINATION "include"
FILES_MATCHING
PATTERN "*.h"
)
else(INSTALL_DEV)
install(
- DIRECTORY "include/tvm/runtime/." DESTINATION "include/tvm/runtime"
+ DIRECTORY "include/tvm/runtime/" DESTINATION "include/tvm/runtime"
FILES_MATCHING
PATTERN "*.h"
)
endif(INSTALL_DEV)
+include(GNUInstallDirs)
+include(CMakePackageConfigHelpers)
+set(PROJECT_CONFIG_CONTENT "@PACKAGE_INIT@\n")
+string(APPEND PROJECT_CONFIG_CONTENT
+ "include(\"\${CMAKE_CURRENT_LIST_DIR}/${PROJECT_NAME}Targets.cmake\")")
+file(WRITE "${CMAKE_CURRENT_BINARY_DIR}/PROJECT_CONFIG_FILE" ${PROJECT_CONFIG_CONTENT})
+
+install(EXPORT ${PROJECT_NAME}Targets
+ NAMESPACE ${PROJECT_NAME}::
+ DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME})
+
+# Create config for find_package()
+configure_package_config_file(
+ "${CMAKE_CURRENT_BINARY_DIR}/PROJECT_CONFIG_FILE" ${PROJECT_NAME}Config.cmake
Review comment:
this to generate temp file, final file name will be "tvmConfig.cmake"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org