You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/08/17 10:47:15 UTC

Review Request 61711: Add CREATE/UPDATE/DELETE actions to alert_definitions event

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61711/
-----------------------------------------------------------

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-21741
    https://issues.apache.org/jira/browse/AMBARI-21741


Repository: ambari


Description
-------


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py b3802b1 
  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 3d7c30c 
  ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 39b88e6 
  ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py 0829c31 
  ambari-agent/src/main/python/ambari_agent/main.py ece9b7a 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 38d0e9e 
  ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definition_expected.json PRE-CREATION 
  ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json cc21244 
  ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_add.json PRE-CREATION 
  ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_delete.json PRE-CREATION 
  ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_edit.json PRE-CREATION 
  ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_small.json PRE-CREATION 


Diff: https://reviews.apache.org/r/61711/diff/1/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 61711: Add CREATE/UPDATE/DELETE actions to alert_definitions event

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61711/#review183116
-----------------------------------------------------------


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Сер. 17, 2017, 10:47 до полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61711/
> -----------------------------------------------------------
> 
> (Updated Сер. 17, 2017, 10:47 до полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21741
>     https://issues.apache.org/jira/browse/AMBARI-21741
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py b3802b1 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 3d7c30c 
>   ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 39b88e6 
>   ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py 0829c31 
>   ambari-agent/src/main/python/ambari_agent/main.py ece9b7a 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 38d0e9e 
>   ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definition_expected.json PRE-CREATION 
>   ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions.json cc21244 
>   ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_add.json PRE-CREATION 
>   ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_delete.json PRE-CREATION 
>   ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_edit.json PRE-CREATION 
>   ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/alert_definitions_small.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61711/diff/1/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>