You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/01/22 10:35:49 UTC
[GitHub] [dubbo-go] yongjiapro opened a new pull request #1008: Refactor Proxy as an interface to allow override impl
yongjiapro opened a new pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008
… needed
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Refactor proxy.Proxy as an interface to allow override impl
修改proxy.Proxy为接口类型，允许项目在自定义ProxyFactory时自定义实现proxy
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
在网关泛调用场景下，当前GenericService实现需要修改对返回数据的处理逻辑。
目前ProxyFactory允许自定义注册，但其创建的proxy.Proxy无法重新实现。
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765316612
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=h1) Report
> Merging [#1008](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=desc) (aa697b0) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/d1365041943d9248c827f2e028293ea10568974d?el=desc) (d136504) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1008 +/- ##
===========================================
- Coverage 59.62% 59.56% -0.07%
===========================================
Files 261 261
Lines 12923 12923
===========================================
- Hits 7705 7697 -8
- Misses 4247 4248 +1
- Partials 971 978 +7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <ø> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <ø> (ø)` | |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.19% <ø> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `74.72% <0.00%> (-4.40%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.05% <0.00%> (-2.95%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `61.11% <0.00%> (+8.33%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=footer). Last update [d136504...ce122fb](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] yongjiapro commented on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
yongjiapro commented on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-766693961
Re-pr a new impl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] yongjiapro closed pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
yongjiapro closed pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765316612
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=h1) Report
> Merging [#1008](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=desc) (2d33936) into [master](https://codecov.io/gh/apache/dubbo-go/commit/9d5dc6117ee3859d09b177cea7dbd2329a4c4812?el=desc) (9d5dc61) will **increase** coverage by `0.15%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
+ Coverage 59.56% 59.71% +0.15%
==========================================
Files 261 261
Lines 12907 12907
==========================================
+ Hits 7688 7708 +20
+ Misses 4245 4228 -17
+ Partials 974 971 -3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.19% <ø> (ø)` | |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <100.00%> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <100.00%> (ø)` | |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `49.79% <0.00%> (-0.41%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `76.92% <0.00%> (+2.19%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `36.80% <0.00%> (+8.79%)` | :arrow_up: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.00% <0.00%> (+8.88%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=footer). Last update [9d5dc61...2d33936](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765316612
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=h1) Report
> Merging [#1008](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=desc) (aa697b0) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/7586ddb44ab25eb2bdd165e72667abbc7d851618?el=desc) (7586ddb) will **decrease** coverage by `0.20%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1008 +/- ##
===========================================
- Coverage 59.76% 59.56% -0.21%
===========================================
Files 261 261
Lines 12923 12923
===========================================
- Hits 7723 7697 -26
- Misses 4226 4248 +22
- Partials 974 978 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <ø> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <ø> (ø)` | |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.19% <ø> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `28.00% <0.00%> (-9.61%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `74.72% <0.00%> (-4.40%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.05% <0.00%> (-2.95%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=footer). Last update [7586ddb...aa697b0](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cityiron commented on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
cityiron commented on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765890166
I want to know more, ps leave a contact information, if you use Dingding, our Group is 31363295.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] yongjiapro commented on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
yongjiapro commented on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765904391
Force update to develop branch, and:
1. Update Proxy to ProxyInterface;
2. Restore Proxy struct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765890194
@yongjiapro hey, guy, give u two suggestions.
1 the target branch of this pr should be develop, not the master branch.
2 U can define a interface whose name maybe ProxyInterface or Interface in k8s style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765316612
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=h1) Report
> Merging [#1008](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=desc) (8c53623) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/7586ddb44ab25eb2bdd165e72667abbc7d851618?el=desc) (7586ddb) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1008 +/- ##
===========================================
- Coverage 59.76% 59.66% -0.10%
===========================================
Files 261 261
Lines 12923 12923
===========================================
- Hits 7723 7711 -12
- Misses 4226 4240 +14
+ Partials 974 972 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <ø> (ø)` | |
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <ø> (ø)` | |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.19% <ø> (ø)` | |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `28.00% <0.00%> (-9.61%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=footer). Last update [7586ddb...aa697b0](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765316612
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=h1) Report
> Merging [#1008](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=desc) (f609be5) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/0cb6edb4dd989696cc56b10259b1e0a146f1c54d?el=desc) (0cb6edb) will **decrease** coverage by `0.07%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #1008 +/- ##
===========================================
- Coverage 59.66% 59.59% -0.08%
===========================================
Files 261 261
Lines 12919 12923 +4
===========================================
- Hits 7708 7701 -7
- Misses 4240 4250 +10
- Partials 971 972 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/proxy/proxy\_factory/default.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5X2ZhY3RvcnkvZGVmYXVsdC5nbw==) | `13.55% <ø> (ø)` | |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.19% <ø> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `63.04% <ø> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `50.36% <57.14%> (-0.77%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `90.19% <100.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1008/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `51.11% <0.00%> (-8.89%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=footer). Last update [9a666eb...f609be5](https://codecov.io/gh/apache/dubbo-go/pull/1008?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#discussion_r563039385
##########
File path: common/proxy/proxy.go
##########
@@ -36,8 +36,17 @@ import (
invocation_impl "github.com/apache/dubbo-go/protocol/invocation"
)
+type Proxy interface {
Review comment:
ProxyInterface or Interface in k8s style
##########
File path: common/proxy/proxy.go
##########
@@ -36,8 +36,17 @@ import (
invocation_impl "github.com/apache/dubbo-go/protocol/invocation"
)
+type Proxy interface {
+ Implement(v common.RPCService)
+ Get() common.RPCService
+ GetCallback() interface{}
+ GetInvoker() protocol.Invoker
+}
+
+var _ Proxy = new(DefaultProxy)
+
// nolint
-type Proxy struct {
+type DefaultProxy struct {
Review comment:
Pls do not change the existing struct name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] yongjiapro commented on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
yongjiapro commented on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765905367
> I want to know more, ps leave a contact information, if you use Dingding, our Group is 31363295.
已发送入群申请
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] yongjiapro commented on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
yongjiapro commented on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-766693961
Re-pr a new impl
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] yongjiapro closed pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
yongjiapro closed pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks edited a comment on pull request #1008: Refactor Proxy as an interface to allow override impl
Posted by GitBox <gi...@apache.org>.
AlexStocks edited a comment on pull request #1008:
URL: https://github.com/apache/dubbo-go/pull/1008#issuecomment-765890194
@yongjiapro hey, guy, give u two suggestions.
1 the target branch of this pr should be develop, not the master branch.
2 U can define an interface whose name maybe ProxyInterface or Interface in k8s style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org