You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "xuxin930 (via GitHub)" <gi...@apache.org> on 2023/09/22 07:26:43 UTC
[GitHub] [nuttx] xuxin930 opened a new pull request, #10763: Unix.mk:replace process substitution to pipe avoid out of order
xuxin930 opened a new pull request, #10763:
URL: https://github.com/apache/nuttx/pull/10763
## Summary
process substitution `>(..)` have different behaviors in different shells
unreliable execution order will lead to the problem of being unable to intercept errors.
pipe are used here to ensure that `kwarning` is generated before the if statement.
## Impact
kconfig warning
## Testing
use CI build to test with and without kconfig warning separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xuxin930 commented on pull request #10763: Unix.mk:replace process substitution to pipe avoid out of order
Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 commented on PR #10763:
URL: https://github.com/apache/nuttx/pull/10763#issuecomment-1732877503
> Hi @xuxin930 , could you please take a look at #10794?
Hi @tmedicci thank you very much for finding this problem.
I have already submitted a fix patch, please review it https://github.com/apache/nuttx/pull/10801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] tmedicci commented on pull request #10763: Unix.mk:replace process substitution to pipe avoid out of order
Posted by "tmedicci (via GitHub)" <gi...@apache.org>.
tmedicci commented on PR #10763:
URL: https://github.com/apache/nuttx/pull/10763#issuecomment-1732586197
Hi @xuxin930 , could you please take a look at https://github.com/apache/nuttx/issues/10794?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xuxin930 commented on a diff in pull request #10763: Unix.mk:replace process substitution to pipe avoid out of order
Posted by "xuxin930 (via GitHub)" <gi...@apache.org>.
xuxin930 commented on code in PR #10763:
URL: https://github.com/apache/nuttx/pull/10763#discussion_r1334226551
##########
tools/Unix.mk:
##########
@@ -648,7 +648,7 @@ else
rm kwarning; \
fi
MODULE_WARNING = "warning: the 'modules' option is not supported"
- PURGE_MODULE_WARNING = 2> >(grep -v ${MODULE_WARNING} | tee kwarning) && ${KCONFIG_WARNING}
+ PURGE_MODULE_WARNING = 2>&1 >/dev/null |grep -v ${MODULE_WARNING} | tee kwarning && ${KCONFIG_WARNING}
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #10763: Unix.mk:replace process substitution to pipe avoid out of order
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10763:
URL: https://github.com/apache/nuttx/pull/10763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10763: Unix.mk:replace process substitution to pipe avoid out of order
Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #10763:
URL: https://github.com/apache/nuttx/pull/10763#discussion_r1334216910
##########
tools/Unix.mk:
##########
@@ -648,7 +648,7 @@ else
rm kwarning; \
fi
MODULE_WARNING = "warning: the 'modules' option is not supported"
- PURGE_MODULE_WARNING = 2> >(grep -v ${MODULE_WARNING} | tee kwarning) && ${KCONFIG_WARNING}
+ PURGE_MODULE_WARNING = 2>&1 >/dev/null |grep -v ${MODULE_WARNING} | tee kwarning && ${KCONFIG_WARNING}
Review Comment:
```suggestion
PURGE_MODULE_WARNING = 2>&1 >/dev/null | grep -v ${MODULE_WARNING} | tee kwarning && ${KCONFIG_WARNING}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org