You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by fhueske <gi...@git.apache.org> on 2017/05/09 09:54:05 UTC
[GitHub] flink pull request #3852: [FLINK-6508] [table] Include license files of pack...
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/3852
[FLINK-6508] [table] Include license files of packaged dependencies.
Adds the license files of Janino and Reflections to the resources folder and copies them into the JAR file under `./META-INF/PACKAGED_LICENSES/`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink table-license
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3852
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3852: [FLINK-6508] [table] Include license files of packaged de...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3852
@StephanEwen, looks good to me. I'll close my PR then. Thanks for taking care of the licenses.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3852: [FLINK-6508] [table] Include license files of packaged de...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3852
@fhueske I worked on getting the ASM license in all shaded JAR files. That change would subsume this one. Can you have a look what you think?
BTW: I could not use the shade resource transformer for the ASM license, because of the way that maven/shade handles relative paths and due to the fact that the resource transformer fails when a dependency already brings the same file.
Lesson learned today: It sounds simple to add a specific file in various projects to a JAR. But to do that with Maven (in a project like Flink) can take the better part of a day ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3852: [FLINK-6508] [table] Include license files of packaged de...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3852
@greghogan the main `LICENSE` file refers only to the source release.
We don't redistribute our dependencies in source or binary there (unlike the javascript libraries for the web UI that we actually do redistribute in source).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3852: [FLINK-6508] [table] Include license files of packaged de...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/3852
Should we add a stronger attribution as in Flink's main `LICENSE` file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3852: [FLINK-6508] [table] Include license files of packaged de...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3852
@fhueske I think the licenses should not be in `src/main/resources`, brause that packs them into the code as well. Then we have the license twice, one packaged from `src/main/resources`, once from the transformer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3852: [FLINK-6508] [table] Include license files of pack...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske closed the pull request at:
https://github.com/apache/flink/pull/3852
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---