You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by Janne Jalkanen <Ja...@ecyrd.com> on 2007/11/06 18:18:09 UTC
Vote: 2.6.0 release
Heya!
I've been checking out the current CVS version (even bought Parallels
and installed my zillion-year-old copy of Windows 98 on it to run
IE ;-), and it seems to work pretty okay.
Now, the question is, esteemed co-developers, can we finally release
2.6.0 and call it a stable? Are there any issues that still need
fixing urgently before a release? Note that this means real
showstoppers only; small things we can fix in 2.6.1...
The reason why I would like to make a 2.6 release is that it would be
the final LGPL-release and we could start then transferring the
codebase to Apache... finally :-)
/Janne
Re: Vote: 2.6.0 release
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Dirk? Your area... :-)
/Janne
On 8 Nov 2007, at 03:24, Murray Altheim wrote:
> Janne,
>
> I know it's by no means a show stopper but I'd like to add the
> template
> feature I've sent in a patch for before, i.e., the optional use of a
> title block. This involves an addition of the TitleBlock.jsp,
> modifying
> Header.jsp to include it, and a change to jspwiki.css to hide it by
> default.
>
> I think this would facilitate development of templates that use a
> title
> block area (which includes about 90% of mine). I can send in a
> patch if
> you're willing.
>
> Cheers,
>
> Murray
>
> ......................................................................
> .....
> Murray Altheim <murray07 at altheim.com>
> === = =
> http://www.altheim.com/murray/
> = = ===
> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk
> = = = =
>
> Boundless wind and moon - the eye within eyes,
> Inexhaustible heaven and earth - the light beyond light,
> The willow dark, the flower bright - ten thousand houses,
> Knock at any door - there's one who will respond.
> -- The Blue Cliff Record
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Dirk Frederickx <di...@gmail.com>.
All,
I'll take a look at the changes related to the template.
Can anyone else look at the other stuff on events etc.
dirk
On Nov 9, 2007 6:01 AM, Murray Altheim <mu...@altheim.com> wrote:
> Okay,
>
> Here's the promised patch. This includes:
>
> * the TitleBlock.jsp and JSP/CSS changes to accommodate, with changes
> as per Dirk's suggestions
> * the i18n patches that separate the greeting and following message as
> used by UserBox.jsp (including the changes to the JSP)
> * slight modification/simplification to WikiPageEvent
> * addition of WikiPageRenameEvent (I *thought* this was already in CVS
> and consider this a really necessary addition, otherwise there's no
> notification on page name changes)
> * change of private to protected on a method in LuceneSearchProvider to
> permit extension
> * added class info to error message output of ClassUtil
>
> AFAIK this completes my proposed changes in readying for 2.6.0.
>
> Have a great weekend!
>
> Murray
>
> ...........................................................................
> Murray Altheim <murray07 at altheim.com> === = =
> http://www.altheim.com/murray/ = = ===
> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
>
> Boundless wind and moon - the eye within eyes,
> Inexhaustible heaven and earth - the light beyond light,
> The willow dark, the flower bright - ten thousand houses,
> Knock at any door - there's one who will respond.
> -- The Blue Cliff Record
>
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
> Sorry about that. The self-referencing line is "Please also read
> and understand the instructions on the ContributingChanges page.".
Heh. Cut-n-paste'o. :)
/Janne
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Craig L Russell <Cr...@Sun.COM>.
On Nov 9, 2007, at 1:46 PM, Janne Jalkanen wrote:
>
> Modified the page accordingly. Which line are you talking about?
Sorry about that. The self-referencing line is "Please also read and
understand the instructions on the ContributingChanges page.".
Craig
> /Janne
>
> On 9 Nov 2007, at 22:58, Craig L Russell wrote:
>
>> Hi Janne,
>>
>> With svn instead of cvs, we might have to update the
>> SubmittingAPatch part. We might think of being more specific as to
>> the patch creation process:
>>
>> To submit a patch, go to the trunk and do svn diff
>> >jspwiki-125.patch where jspwiki-125 is the jira issue.
>>
>> The line "" seems to be unneeded, as it refers to itself.
>>
>> Craig
>>
>> On Nov 9, 2007, at 12:20 PM, Janne Jalkanen wrote:
>>
>>>
>>> Added some discussion to
>>>
>>> http://www.jspwiki.org/wiki/ContributingChanges
>>>
>>> How does that sound?
>>>
>>> /Janne
>>>
>>> On 9 Nov 2007, at 22:00, Janne Jalkanen wrote:
>>>
>>>>
>>>> Sounds like a good policy to me. It also means that patches
>>>> don't disappear in the email inboxes - which often tends to happen.
>>>>
>>>> As an example, the TitleBlock should probably be a separate
>>>> patch, and also the i18n change (as it impacts much more than
>>>> just a simple file), as well as the WikiRenamePageEvent. The
>>>> other stuff should go in right away, IMHO.
>>>>
>>>> And separate patches, please. I really hate it when a patch has
>>>> multiple functionalities...
>>>>
>>>> *sigh*
>>>>
>>>> Too bad we don't have Git or Mercurial. It would be so much
>>>> easier to manage branches than with SVN...
>>>>
>>>> /Janne
>>>>
>>>> On 9 Nov 2007, at 21:39, Craig L Russell wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> In order to attract community contributors it would be good to
>>>>> standardize patch contributions.
>>>>>
>>>>> Many other projects recommend for non-trivial patches, a JIRA
>>>>> to be open and a patch to be attached to the JIRA. It's easier
>>>>> to review patches attached to a JIRA; all you need to do is to
>>>>> click on the attachment and it appears in a browser window.
>>>>>
>>>>> Clearly any committer has the ability to commit at will. But if
>>>>> the patch needs to be reviewed, a JIRA issue with a discussion
>>>>> is a great way to capture everyone's feedback in one place.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Craig
>>>>>
>>>>> On Nov 9, 2007, at 11:20 AM, Janne Jalkanen wrote:
>>>>>
>>>>>>> * the TitleBlock.jsp and JSP/CSS changes to accommodate, with
>>>>>>> changes
>>>>>>> as per Dirk's suggestions
>>>>>>
>>>>>> These are dirk's domain...
>>>>>>
>>>>>>> * the i18n patches that separate the greeting and following
>>>>>>> message as
>>>>>>> used by UserBox.jsp (including the changes to the JSP)
>>>>>>
>>>>>> Didn't take these in, as the patch wasn't clean - it failed on
>>>>>> everything but English. Also, they seemed to have loads of
>>>>>> other changes as well, which I wasn't too comfortable with.
>>>>>>
>>>>>>> * slight modification/simplification to WikiPageEvent
>>>>>>> * addition of WikiPageRenameEvent (I *thought* this was
>>>>>>> already in CVS
>>>>>>> and consider this a really necessary addition, otherwise
>>>>>>> there's no
>>>>>>> notification on page name changes)
>>>>>>> * change of private to protected on a method in
>>>>>>> LuceneSearchProvider to
>>>>>>> permit extension
>>>>>>> * added class info to error message output of ClassUtil
>>>>>>
>>>>>> The rest are in.
>>>>>>
>>>>>> I'm still wondering though why you don't put these in yourself
>>>>>> - you *do* have commit access to the CVS... ;-)
>>>>>>
>>>>>> /Janne
>>>>>
>>>>> Craig Russell
>>>>> Architect, Sun Java Enterprise System http://java.sun.com/
>>>>> products/jdo
>>>>> 408 276-5638 mailto:Craig.Russell@sun.com
>>>>> P.S. A good JDO? O, Gasp!
>>>>>
>>>
>>
>> Craig Russell
>> Architect, Sun Java Enterprise System http://java.sun.com/products/
>> jdo
>> 408 276-5638 mailto:Craig.Russell@sun.com
>> P.S. A good JDO? O, Gasp!
>>
>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Modified the page accordingly. Which line are you talking about?
/Janne
On 9 Nov 2007, at 22:58, Craig L Russell wrote:
> Hi Janne,
>
> With svn instead of cvs, we might have to update the
> SubmittingAPatch part. We might think of being more specific as to
> the patch creation process:
>
> To submit a patch, go to the trunk and do svn diff
> >jspwiki-125.patch where jspwiki-125 is the jira issue.
>
> The line "" seems to be unneeded, as it refers to itself.
>
> Craig
>
> On Nov 9, 2007, at 12:20 PM, Janne Jalkanen wrote:
>
>>
>> Added some discussion to
>>
>> http://www.jspwiki.org/wiki/ContributingChanges
>>
>> How does that sound?
>>
>> /Janne
>>
>> On 9 Nov 2007, at 22:00, Janne Jalkanen wrote:
>>
>>>
>>> Sounds like a good policy to me. It also means that patches
>>> don't disappear in the email inboxes - which often tends to happen.
>>>
>>> As an example, the TitleBlock should probably be a separate
>>> patch, and also the i18n change (as it impacts much more than
>>> just a simple file), as well as the WikiRenamePageEvent. The
>>> other stuff should go in right away, IMHO.
>>>
>>> And separate patches, please. I really hate it when a patch has
>>> multiple functionalities...
>>>
>>> *sigh*
>>>
>>> Too bad we don't have Git or Mercurial. It would be so much
>>> easier to manage branches than with SVN...
>>>
>>> /Janne
>>>
>>> On 9 Nov 2007, at 21:39, Craig L Russell wrote:
>>>
>>>> Hi,
>>>>
>>>> In order to attract community contributors it would be good to
>>>> standardize patch contributions.
>>>>
>>>> Many other projects recommend for non-trivial patches, a JIRA to
>>>> be open and a patch to be attached to the JIRA. It's easier to
>>>> review patches attached to a JIRA; all you need to do is to
>>>> click on the attachment and it appears in a browser window.
>>>>
>>>> Clearly any committer has the ability to commit at will. But if
>>>> the patch needs to be reviewed, a JIRA issue with a discussion
>>>> is a great way to capture everyone's feedback in one place.
>>>>
>>>> Regards,
>>>>
>>>> Craig
>>>>
>>>> On Nov 9, 2007, at 11:20 AM, Janne Jalkanen wrote:
>>>>
>>>>>> * the TitleBlock.jsp and JSP/CSS changes to accommodate, with
>>>>>> changes
>>>>>> as per Dirk's suggestions
>>>>>
>>>>> These are dirk's domain...
>>>>>
>>>>>> * the i18n patches that separate the greeting and following
>>>>>> message as
>>>>>> used by UserBox.jsp (including the changes to the JSP)
>>>>>
>>>>> Didn't take these in, as the patch wasn't clean - it failed on
>>>>> everything but English. Also, they seemed to have loads of
>>>>> other changes as well, which I wasn't too comfortable with.
>>>>>
>>>>>> * slight modification/simplification to WikiPageEvent
>>>>>> * addition of WikiPageRenameEvent (I *thought* this was
>>>>>> already in CVS
>>>>>> and consider this a really necessary addition, otherwise
>>>>>> there's no
>>>>>> notification on page name changes)
>>>>>> * change of private to protected on a method in
>>>>>> LuceneSearchProvider to
>>>>>> permit extension
>>>>>> * added class info to error message output of ClassUtil
>>>>>
>>>>> The rest are in.
>>>>>
>>>>> I'm still wondering though why you don't put these in yourself
>>>>> - you *do* have commit access to the CVS... ;-)
>>>>>
>>>>> /Janne
>>>>
>>>> Craig Russell
>>>> Architect, Sun Java Enterprise System http://java.sun.com/
>>>> products/jdo
>>>> 408 276-5638 mailto:Craig.Russell@sun.com
>>>> P.S. A good JDO? O, Gasp!
>>>>
>>
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Craig L Russell <Cr...@Sun.COM>.
Hi Janne,
With svn instead of cvs, we might have to update the SubmittingAPatch
part. We might think of being more specific as to the patch creation
process:
To submit a patch, go to the trunk and do svn diff >jspwiki-125.patch
where jspwiki-125 is the jira issue.
The line "" seems to be unneeded, as it refers to itself.
Craig
On Nov 9, 2007, at 12:20 PM, Janne Jalkanen wrote:
>
> Added some discussion to
>
> http://www.jspwiki.org/wiki/ContributingChanges
>
> How does that sound?
>
> /Janne
>
> On 9 Nov 2007, at 22:00, Janne Jalkanen wrote:
>
>>
>> Sounds like a good policy to me. It also means that patches don't
>> disappear in the email inboxes - which often tends to happen.
>>
>> As an example, the TitleBlock should probably be a separate patch,
>> and also the i18n change (as it impacts much more than just a
>> simple file), as well as the WikiRenamePageEvent. The other stuff
>> should go in right away, IMHO.
>>
>> And separate patches, please. I really hate it when a patch has
>> multiple functionalities...
>>
>> *sigh*
>>
>> Too bad we don't have Git or Mercurial. It would be so much
>> easier to manage branches than with SVN...
>>
>> /Janne
>>
>> On 9 Nov 2007, at 21:39, Craig L Russell wrote:
>>
>>> Hi,
>>>
>>> In order to attract community contributors it would be good to
>>> standardize patch contributions.
>>>
>>> Many other projects recommend for non-trivial patches, a JIRA to
>>> be open and a patch to be attached to the JIRA. It's easier to
>>> review patches attached to a JIRA; all you need to do is to click
>>> on the attachment and it appears in a browser window.
>>>
>>> Clearly any committer has the ability to commit at will. But if
>>> the patch needs to be reviewed, a JIRA issue with a discussion is
>>> a great way to capture everyone's feedback in one place.
>>>
>>> Regards,
>>>
>>> Craig
>>>
>>> On Nov 9, 2007, at 11:20 AM, Janne Jalkanen wrote:
>>>
>>>>> * the TitleBlock.jsp and JSP/CSS changes to accommodate, with
>>>>> changes
>>>>> as per Dirk's suggestions
>>>>
>>>> These are dirk's domain...
>>>>
>>>>> * the i18n patches that separate the greeting and following
>>>>> message as
>>>>> used by UserBox.jsp (including the changes to the JSP)
>>>>
>>>> Didn't take these in, as the patch wasn't clean - it failed on
>>>> everything but English. Also, they seemed to have loads of
>>>> other changes as well, which I wasn't too comfortable with.
>>>>
>>>>> * slight modification/simplification to WikiPageEvent
>>>>> * addition of WikiPageRenameEvent (I *thought* this was already
>>>>> in CVS
>>>>> and consider this a really necessary addition, otherwise
>>>>> there's no
>>>>> notification on page name changes)
>>>>> * change of private to protected on a method in
>>>>> LuceneSearchProvider to
>>>>> permit extension
>>>>> * added class info to error message output of ClassUtil
>>>>
>>>> The rest are in.
>>>>
>>>> I'm still wondering though why you don't put these in yourself -
>>>> you *do* have commit access to the CVS... ;-)
>>>>
>>>> /Janne
>>>
>>> Craig Russell
>>> Architect, Sun Java Enterprise System http://java.sun.com/
>>> products/jdo
>>> 408 276-5638 mailto:Craig.Russell@sun.com
>>> P.S. A good JDO? O, Gasp!
>>>
>
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Added some discussion to
http://www.jspwiki.org/wiki/ContributingChanges
How does that sound?
/Janne
On 9 Nov 2007, at 22:00, Janne Jalkanen wrote:
>
> Sounds like a good policy to me. It also means that patches don't
> disappear in the email inboxes - which often tends to happen.
>
> As an example, the TitleBlock should probably be a separate patch,
> and also the i18n change (as it impacts much more than just a
> simple file), as well as the WikiRenamePageEvent. The other stuff
> should go in right away, IMHO.
>
> And separate patches, please. I really hate it when a patch has
> multiple functionalities...
>
> *sigh*
>
> Too bad we don't have Git or Mercurial. It would be so much easier
> to manage branches than with SVN...
>
> /Janne
>
> On 9 Nov 2007, at 21:39, Craig L Russell wrote:
>
>> Hi,
>>
>> In order to attract community contributors it would be good to
>> standardize patch contributions.
>>
>> Many other projects recommend for non-trivial patches, a JIRA to
>> be open and a patch to be attached to the JIRA. It's easier to
>> review patches attached to a JIRA; all you need to do is to click
>> on the attachment and it appears in a browser window.
>>
>> Clearly any committer has the ability to commit at will. But if
>> the patch needs to be reviewed, a JIRA issue with a discussion is
>> a great way to capture everyone's feedback in one place.
>>
>> Regards,
>>
>> Craig
>>
>> On Nov 9, 2007, at 11:20 AM, Janne Jalkanen wrote:
>>
>>>> * the TitleBlock.jsp and JSP/CSS changes to accommodate, with
>>>> changes
>>>> as per Dirk's suggestions
>>>
>>> These are dirk's domain...
>>>
>>>> * the i18n patches that separate the greeting and following
>>>> message as
>>>> used by UserBox.jsp (including the changes to the JSP)
>>>
>>> Didn't take these in, as the patch wasn't clean - it failed on
>>> everything but English. Also, they seemed to have loads of other
>>> changes as well, which I wasn't too comfortable with.
>>>
>>>> * slight modification/simplification to WikiPageEvent
>>>> * addition of WikiPageRenameEvent (I *thought* this was already
>>>> in CVS
>>>> and consider this a really necessary addition, otherwise
>>>> there's no
>>>> notification on page name changes)
>>>> * change of private to protected on a method in
>>>> LuceneSearchProvider to
>>>> permit extension
>>>> * added class info to error message output of ClassUtil
>>>
>>> The rest are in.
>>>
>>> I'm still wondering though why you don't put these in yourself -
>>> you *do* have commit access to the CVS... ;-)
>>>
>>> /Janne
>>
>> Craig Russell
>> Architect, Sun Java Enterprise System http://java.sun.com/products/
>> jdo
>> 408 276-5638 mailto:Craig.Russell@sun.com
>> P.S. A good JDO? O, Gasp!
>>
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Sounds like a good policy to me. It also means that patches don't
disappear in the email inboxes - which often tends to happen.
As an example, the TitleBlock should probably be a separate patch,
and also the i18n change (as it impacts much more than just a simple
file), as well as the WikiRenamePageEvent. The other stuff should go
in right away, IMHO.
And separate patches, please. I really hate it when a patch has
multiple functionalities...
*sigh*
Too bad we don't have Git or Mercurial. It would be so much easier
to manage branches than with SVN...
/Janne
On 9 Nov 2007, at 21:39, Craig L Russell wrote:
> Hi,
>
> In order to attract community contributors it would be good to
> standardize patch contributions.
>
> Many other projects recommend for non-trivial patches, a JIRA to be
> open and a patch to be attached to the JIRA. It's easier to review
> patches attached to a JIRA; all you need to do is to click on the
> attachment and it appears in a browser window.
>
> Clearly any committer has the ability to commit at will. But if the
> patch needs to be reviewed, a JIRA issue with a discussion is a
> great way to capture everyone's feedback in one place.
>
> Regards,
>
> Craig
>
> On Nov 9, 2007, at 11:20 AM, Janne Jalkanen wrote:
>
>>> * the TitleBlock.jsp and JSP/CSS changes to accommodate, with
>>> changes
>>> as per Dirk's suggestions
>>
>> These are dirk's domain...
>>
>>> * the i18n patches that separate the greeting and following
>>> message as
>>> used by UserBox.jsp (including the changes to the JSP)
>>
>> Didn't take these in, as the patch wasn't clean - it failed on
>> everything but English. Also, they seemed to have loads of other
>> changes as well, which I wasn't too comfortable with.
>>
>>> * slight modification/simplification to WikiPageEvent
>>> * addition of WikiPageRenameEvent (I *thought* this was already
>>> in CVS
>>> and consider this a really necessary addition, otherwise
>>> there's no
>>> notification on page name changes)
>>> * change of private to protected on a method in
>>> LuceneSearchProvider to
>>> permit extension
>>> * added class info to error message output of ClassUtil
>>
>> The rest are in.
>>
>> I'm still wondering though why you don't put these in yourself -
>> you *do* have commit access to the CVS... ;-)
>>
>> /Janne
>
> Craig Russell
> Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
> 408 276-5638 mailto:Craig.Russell@sun.com
> P.S. A good JDO? O, Gasp!
>
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Craig L Russell <Cr...@Sun.COM>.
Hi,
In order to attract community contributors it would be good to
standardize patch contributions.
Many other projects recommend for non-trivial patches, a JIRA to be
open and a patch to be attached to the JIRA. It's easier to review
patches attached to a JIRA; all you need to do is to click on the
attachment and it appears in a browser window.
Clearly any committer has the ability to commit at will. But if the
patch needs to be reviewed, a JIRA issue with a discussion is a great
way to capture everyone's feedback in one place.
Regards,
Craig
On Nov 9, 2007, at 11:20 AM, Janne Jalkanen wrote:
>> * the TitleBlock.jsp and JSP/CSS changes to accommodate, with changes
>> as per Dirk's suggestions
>
> These are dirk's domain...
>
>> * the i18n patches that separate the greeting and following
>> message as
>> used by UserBox.jsp (including the changes to the JSP)
>
> Didn't take these in, as the patch wasn't clean - it failed on
> everything but English. Also, they seemed to have loads of other
> changes as well, which I wasn't too comfortable with.
>
>> * slight modification/simplification to WikiPageEvent
>> * addition of WikiPageRenameEvent (I *thought* this was already in
>> CVS
>> and consider this a really necessary addition, otherwise there's no
>> notification on page name changes)
>> * change of private to protected on a method in
>> LuceneSearchProvider to
>> permit extension
>> * added class info to error message output of ClassUtil
>
> The rest are in.
>
> I'm still wondering though why you don't put these in yourself -
> you *do* have commit access to the CVS... ;-)
>
> /Janne
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Murray Altheim <mu...@altheim.com>.
Janne Jalkanen wrote:
>> * the TitleBlock.jsp and JSP/CSS changes to accommodate, with changes
>> as per Dirk's suggestions
>
> These are dirk's domain...
ok.
>> * the i18n patches that separate the greeting and following message as
>> used by UserBox.jsp (including the changes to the JSP)
>
> Didn't take these in, as the patch wasn't clean - it failed on
> everything but English. Also, they seemed to have loads of other
> changes as well, which I wasn't too comfortable with.
I'd known there was some issue with encoding on diffs, or something
going wrong.
>> * slight modification/simplification to WikiPageEvent
>> * addition of WikiPageRenameEvent (I *thought* this was already in CVS
>> and consider this a really necessary addition, otherwise there's no
>> notification on page name changes)
>> * change of private to protected on a method in LuceneSearchProvider to
>> permit extension
>> * added class info to error message output of ClassUtil
>
> The rest are in.
>
> I'm still wondering though why you don't put these in yourself - you
> *do* have commit access to the CVS... ;-)
Mostly for review, partly because I as unsure about several things, and
[certainly] partly because of lack of time -- I managed to get that patch
to you in the very small window of time I had. I haven't had the time to
figure to even look into the CVS yet. *sigh*
And apologies on not sending separate patches- could do that. Still not
sure what's up with the encoding -- I think you mentioned that all the
l10n stuff is Latin rather than UTF-8 so I'll check again and resend,
or if I find the time this weekend, commit to CVS. I'm more comfortable
on this encoding issue if I send and it fails than me committing a
wrongly-encoded file.
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
> * the TitleBlock.jsp and JSP/CSS changes to accommodate, with changes
> as per Dirk's suggestions
These are dirk's domain...
> * the i18n patches that separate the greeting and following message as
> used by UserBox.jsp (including the changes to the JSP)
Didn't take these in, as the patch wasn't clean - it failed on
everything but English. Also, they seemed to have loads of other
changes as well, which I wasn't too comfortable with.
> * slight modification/simplification to WikiPageEvent
> * addition of WikiPageRenameEvent (I *thought* this was already in CVS
> and consider this a really necessary addition, otherwise there's no
> notification on page name changes)
> * change of private to protected on a method in
> LuceneSearchProvider to
> permit extension
> * added class info to error message output of ClassUtil
The rest are in.
I'm still wondering though why you don't put these in yourself - you
*do* have commit access to the CVS... ;-)
/Janne
Event and i18n Patches [Was: Vote: 2.6.0 release]
Posted by Murray Altheim <mu...@altheim.com>.
Okay,
Here's the promised patch. This includes:
* the TitleBlock.jsp and JSP/CSS changes to accommodate, with changes
as per Dirk's suggestions
* the i18n patches that separate the greeting and following message as
used by UserBox.jsp (including the changes to the JSP)
* slight modification/simplification to WikiPageEvent
* addition of WikiPageRenameEvent (I *thought* this was already in CVS
and consider this a really necessary addition, otherwise there's no
notification on page name changes)
* change of private to protected on a method in LuceneSearchProvider to
permit extension
* added class info to error message output of ClassUtil
AFAIK this completes my proposed changes in readying for 2.6.0.
Have a great weekend!
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: Vote: 2.6.0 release
Posted by Murray Altheim <mu...@altheim.com>.
Janne Jalkanen wrote:
>
> No, I meant whether this would appear on top of everything, or between
> the title and the page content.
Certainly this could be set by the CSS, but in my use it appears on
top of everything, from 0,0 to page.width,titleblock.height, and
with a high z-index number:
In Header.jsp:
<div id="header">
<wiki:Include page="TitleBlock.jsp" />
<div class="applicationlogo" >
...
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: Vote: 2.6.0 release
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
No, I meant whether this would appear on top of everything, or
between the title and the page content.
/Janne
On 9 Nov 2007, at 00:50, Murray Altheim wrote:
> Janne Jalkanen wrote:
>> Is that a part of the pagecontent or the entire web page?
>
> Not sure of the question entirely, but it basically is a single
> TitleBlock.jsp that looks for a wiki page called TitleBlock. If
> that page exists its content is included in a titleblock that
> appears at the top of the page, e.g., formatted as a 100% width
> banner across the top of the page. I.e., if the skin overrides
> the CSS in jspwiki.css that by default hides the title block:
>
> #titleblock {
> display:none;
> }
>
> In most of my skins this is changed to something akin to:
>
> #header #titleblock {
> z-index : 777 ;
> display:block;
> position: absolute ; left: 0px; top: 0px; text-align: left;
> height : 90px ; width : 100% ; vertical-align : middle ;
> background-color : #307879 ; color : white ;
> padding : 0em 1em 0.1em 20px ;
> margin-bottom : 0em ; margin-top : 0em ;
> border-bottom: 3px #c0d4cc solid;
> }
>
> with appropriate alterations for any internal content (h1, h2, etc.).
>
> Does that answer the question? I'm planning on submitting a template
> once things settle down that uses the TitleBlock.jsp, probably one
> for the Church of the Flying Spaghetti Monster (I have permission to
> the logo!).
>
> Murray
>
>> /Janne
>> On 8 Nov 2007, at 23:29, Dirk Frederickx wrote:
>>> Murray,
>>>
>>> Sound like a good idea. Similar to CopyrightNotice in the footer, we
>>> could add a title box in the header.
>>>
>>> I would prefer not to put any predefined format or contents in it
>>> (like suggested in your previous patch) but only show that content
>>> when the page exists.
>>> So, a new block could be added to the header:
>>>
>>> <div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
>>>
>>>
>>> Any votes for this ?
>
> .....................................................................
> ......
> Murray Altheim <murray07 at altheim.com>
> === = =
> http://www.altheim.com/murray/
> = = ===
> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk
> = = = =
>
> Boundless wind and moon - the eye within eyes,
> Inexhaustible heaven and earth - the light beyond light,
> The willow dark, the flower bright - ten thousand houses,
> Knock at any door - there's one who will respond.
> -- The Blue Cliff Record
Re: Vote: 2.6.0 release
Posted by Murray Altheim <mu...@altheim.com>.
Janne Jalkanen wrote:
>
> Is that a part of the pagecontent or the entire web page?
Not sure of the question entirely, but it basically is a single
TitleBlock.jsp that looks for a wiki page called TitleBlock. If
that page exists its content is included in a titleblock that
appears at the top of the page, e.g., formatted as a 100% width
banner across the top of the page. I.e., if the skin overrides
the CSS in jspwiki.css that by default hides the title block:
#titleblock {
display:none;
}
In most of my skins this is changed to something akin to:
#header #titleblock {
z-index : 777 ;
display:block;
position: absolute ; left: 0px; top: 0px; text-align: left;
height : 90px ; width : 100% ; vertical-align : middle ;
background-color : #307879 ; color : white ;
padding : 0em 1em 0.1em 20px ;
margin-bottom : 0em ; margin-top : 0em ;
border-bottom: 3px #c0d4cc solid;
}
with appropriate alterations for any internal content (h1, h2, etc.).
Does that answer the question? I'm planning on submitting a template
once things settle down that uses the TitleBlock.jsp, probably one
for the Church of the Flying Spaghetti Monster (I have permission to
the logo!).
Murray
> /Janne
>
> On 8 Nov 2007, at 23:29, Dirk Frederickx wrote:
>
>> Murray,
>>
>> Sound like a good idea. Similar to CopyrightNotice in the footer, we
>> could add a title box in the header.
>>
>> I would prefer not to put any predefined format or contents in it
>> (like suggested in your previous patch) but only show that content
>> when the page exists.
>> So, a new block could be added to the header:
>>
>> <div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
>>
>>
>> Any votes for this ?
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: Vote: 2.6.0 release
Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi!
I've thought another suggestion: what about adding a new js file to handle
custom onload events? ie: the GoogleMaps Plugin needs an initialize()
function when the page has finalized loading. Something similar to
localheader.jsp, but used to handle custom javascript onload events.
Regards,
JP
p.s.: Um, well, after looking into googlemaps api
docs<http://www.google.com/apis/maps/documentation/#Memory_Leaks>,
I'd say what about also adding another .js method to handle body onunload
events?
2007/11/9, Dirk Frederickx <di...@gmail.com>:
>
> This title block could obviously also function as a 'global
> announcement block', as it will appear as a first block at the top of
> the wiki header page.
> I don't think there is a need for an additional block.
>
> dirk
>
> On Nov 9, 2007 12:03 PM, Janne Jalkanen <Ja...@ecyrd.com> wrote:
> >
> > In that case, I think we should have a "global announcements block"
> > as well :-). I've found that it would be very useful on jspwiki.org
> > for example, when you can't assume that people come in through the
> > front page.
> >
> > /Janne
> >
> >
> > On 9 Nov 2007, at 12:04, Murray Altheim wrote:
> >
> > > Janne Jalkanen wrote:
> > >> I was just wondering whether for usability purposes it would be
> > >> better if it was below the header but before page content. That
> > >> way navigation would stay in constant place regardless of whether
> > >> this "global notice" existed or not.
> > >> /Janne
> > >
> > > Well, the TitleBlock is really intended to be the site title, i.e.,
> > > it's
> > > in some ways even more important than the navigation in that this
> > > is where
> > > the site's banner, logo, and/or title live. In my own templates
> > > that use
> > > this the wiki page name and all navigation information is placed
> > > just below
> > > the static title block. Like I mentioned, I'll likely be able to
> > > provide
> > > a 2.6.0-ready template soon after things stabilize.
> > >
> > > Murray
> > >
> > > ......................................................................
> > > .....
> > > Murray Altheim <murray07 at altheim.com>
> > > === = =
> > > http://www.altheim.com/murray/
> > > = = ===
> > > SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk
> > > = = = =
> > >
> > > Boundless wind and moon - the eye within eyes,
> > > Inexhaustible heaven and earth - the light beyond light,
> > > The willow dark, the flower bright - ten thousand houses,
> > > Knock at any door - there's one who will respond.
> > > -- The Blue Cliff Record
> >
> >
>
Re: Vote: 2.6.0 release
Posted by Dirk Frederickx <di...@gmail.com>.
This title block could obviously also function as a 'global
announcement block', as it will appear as a first block at the top of
the wiki header page.
I don't think there is a need for an additional block.
dirk
On Nov 9, 2007 12:03 PM, Janne Jalkanen <Ja...@ecyrd.com> wrote:
>
> In that case, I think we should have a "global announcements block"
> as well :-). I've found that it would be very useful on jspwiki.org
> for example, when you can't assume that people come in through the
> front page.
>
> /Janne
>
>
> On 9 Nov 2007, at 12:04, Murray Altheim wrote:
>
> > Janne Jalkanen wrote:
> >> I was just wondering whether for usability purposes it would be
> >> better if it was below the header but before page content. That
> >> way navigation would stay in constant place regardless of whether
> >> this "global notice" existed or not.
> >> /Janne
> >
> > Well, the TitleBlock is really intended to be the site title, i.e.,
> > it's
> > in some ways even more important than the navigation in that this
> > is where
> > the site's banner, logo, and/or title live. In my own templates
> > that use
> > this the wiki page name and all navigation information is placed
> > just below
> > the static title block. Like I mentioned, I'll likely be able to
> > provide
> > a 2.6.0-ready template soon after things stabilize.
> >
> > Murray
> >
> > ......................................................................
> > .....
> > Murray Altheim <murray07 at altheim.com>
> > === = =
> > http://www.altheim.com/murray/
> > = = ===
> > SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk
> > = = = =
> >
> > Boundless wind and moon - the eye within eyes,
> > Inexhaustible heaven and earth - the light beyond light,
> > The willow dark, the flower bright - ten thousand houses,
> > Knock at any door - there's one who will respond.
> > -- The Blue Cliff Record
>
>
Re: Vote: 2.6.0 release
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
In that case, I think we should have a "global announcements block"
as well :-). I've found that it would be very useful on jspwiki.org
for example, when you can't assume that people come in through the
front page.
/Janne
On 9 Nov 2007, at 12:04, Murray Altheim wrote:
> Janne Jalkanen wrote:
>> I was just wondering whether for usability purposes it would be
>> better if it was below the header but before page content. That
>> way navigation would stay in constant place regardless of whether
>> this "global notice" existed or not.
>> /Janne
>
> Well, the TitleBlock is really intended to be the site title, i.e.,
> it's
> in some ways even more important than the navigation in that this
> is where
> the site's banner, logo, and/or title live. In my own templates
> that use
> this the wiki page name and all navigation information is placed
> just below
> the static title block. Like I mentioned, I'll likely be able to
> provide
> a 2.6.0-ready template soon after things stabilize.
>
> Murray
>
> ......................................................................
> .....
> Murray Altheim <murray07 at altheim.com>
> === = =
> http://www.altheim.com/murray/
> = = ===
> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk
> = = = =
>
> Boundless wind and moon - the eye within eyes,
> Inexhaustible heaven and earth - the light beyond light,
> The willow dark, the flower bright - ten thousand houses,
> Knock at any door - there's one who will respond.
> -- The Blue Cliff Record
Re: Vote: 2.6.0 release
Posted by Murray Altheim <mu...@altheim.com>.
Janne Jalkanen wrote:
>
> I was just wondering whether for usability purposes it would be better
> if it was below the header but before page content. That way navigation
> would stay in constant place regardless of whether this "global notice"
> existed or not.
>
> /Janne
Well, the TitleBlock is really intended to be the site title, i.e., it's
in some ways even more important than the navigation in that this is where
the site's banner, logo, and/or title live. In my own templates that use
this the wiki page name and all navigation information is placed just below
the static title block. Like I mentioned, I'll likely be able to provide
a 2.6.0-ready template soon after things stabilize.
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: Vote: 2.6.0 release
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
I was just wondering whether for usability purposes it would be
better if it was below the header but before page content. That way
navigation would stay in constant place regardless of whether this
"global notice" existed or not.
/Janne
On 9 Nov 2007, at 08:55, Dirk Frederickx wrote:
> Part of the Header.
> When the TitleBox exist, you would see extra text/info inside the
> header box, at the top of the page.
> Obviously, with css you could change the look and feel of the title
> stuff as appropriate.
>
>
> dirk
>
> On Nov 8, 2007 10:31 PM, Janne Jalkanen <Ja...@ecyrd.com>
> wrote:
>>
>> Is that a part of the pagecontent or the entire web page?
>>
>> /Janne
>>
>>
>> On 8 Nov 2007, at 23:29, Dirk Frederickx wrote:
>>
>>> Murray,
>>>
>>> Sound like a good idea. Similar to CopyrightNotice in the footer, we
>>> could add a title box in the header.
>>>
>>> I would prefer not to put any predefined format or contents in it
>>> (like suggested in your previous patch) but only show that content
>>> when the page exists.
>>> So, a new block could be added to the header:
>>>
>>> <div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
>>>
>>>
>>> Any votes for this ?
>>>
>>> dirk
>>>
>>>
>>>
>>> On Nov 8, 2007 2:24 AM, Murray Altheim <mu...@altheim.com> wrote:
>>>> Janne,
>>>>
>>>> I know it's by no means a show stopper but I'd like to add the
>>>> template
>>>> feature I've sent in a patch for before, i.e., the optional use
>>>> of a
>>>> title block. This involves an addition of the TitleBlock.jsp,
>>>> modifying
>>>> Header.jsp to include it, and a change to jspwiki.css to hide it by
>>>> default.
>>>>
>>>> I think this would facilitate development of templates that use a
>>>> title
>>>> block area (which includes about 90% of mine). I can send in a
>>>> patch if
>>>> you're willing.
>>>>
>>>> Cheers,
>>>>
>>>> Murray
>>>>
>>>> ...................................................................
>>>> ..
>>>> ......
>>>> Murray Altheim <murray07 at altheim.com>
>>>> === = =
>>>> http://www.altheim.com/murray/
>>>> = = ===
>>>> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk
>>>> = = = =
>>>>
>>>> Boundless wind and moon - the eye within eyes,
>>>> Inexhaustible heaven and earth - the light beyond light,
>>>> The willow dark, the flower bright - ten thousand houses,
>>>> Knock at any door - there's one who will respond.
>>>> -- The Blue Cliff Record
>>>>
>>
>>
Re: Vote: 2.6.0 release
Posted by Dirk Frederickx <di...@gmail.com>.
Part of the Header.
When the TitleBox exist, you would see extra text/info inside the
header box, at the top of the page.
Obviously, with css you could change the look and feel of the title
stuff as appropriate.
dirk
On Nov 8, 2007 10:31 PM, Janne Jalkanen <Ja...@ecyrd.com> wrote:
>
> Is that a part of the pagecontent or the entire web page?
>
> /Janne
>
>
> On 8 Nov 2007, at 23:29, Dirk Frederickx wrote:
>
> > Murray,
> >
> > Sound like a good idea. Similar to CopyrightNotice in the footer, we
> > could add a title box in the header.
> >
> > I would prefer not to put any predefined format or contents in it
> > (like suggested in your previous patch) but only show that content
> > when the page exists.
> > So, a new block could be added to the header:
> >
> > <div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
> >
> >
> > Any votes for this ?
> >
> > dirk
> >
> >
> >
> > On Nov 8, 2007 2:24 AM, Murray Altheim <mu...@altheim.com> wrote:
> >> Janne,
> >>
> >> I know it's by no means a show stopper but I'd like to add the
> >> template
> >> feature I've sent in a patch for before, i.e., the optional use of a
> >> title block. This involves an addition of the TitleBlock.jsp,
> >> modifying
> >> Header.jsp to include it, and a change to jspwiki.css to hide it by
> >> default.
> >>
> >> I think this would facilitate development of templates that use a
> >> title
> >> block area (which includes about 90% of mine). I can send in a
> >> patch if
> >> you're willing.
> >>
> >> Cheers,
> >>
> >> Murray
> >>
> >> .....................................................................
> >> ......
> >> Murray Altheim <murray07 at altheim.com>
> >> === = =
> >> http://www.altheim.com/murray/
> >> = = ===
> >> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk
> >> = = = =
> >>
> >> Boundless wind and moon - the eye within eyes,
> >> Inexhaustible heaven and earth - the light beyond light,
> >> The willow dark, the flower bright - ten thousand houses,
> >> Knock at any door - there's one who will respond.
> >> -- The Blue Cliff Record
> >>
>
>
Re: Vote: 2.6.0 release
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Is that a part of the pagecontent or the entire web page?
/Janne
On 8 Nov 2007, at 23:29, Dirk Frederickx wrote:
> Murray,
>
> Sound like a good idea. Similar to CopyrightNotice in the footer, we
> could add a title box in the header.
>
> I would prefer not to put any predefined format or contents in it
> (like suggested in your previous patch) but only show that content
> when the page exists.
> So, a new block could be added to the header:
>
> <div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
>
>
> Any votes for this ?
>
> dirk
>
>
>
> On Nov 8, 2007 2:24 AM, Murray Altheim <mu...@altheim.com> wrote:
>> Janne,
>>
>> I know it's by no means a show stopper but I'd like to add the
>> template
>> feature I've sent in a patch for before, i.e., the optional use of a
>> title block. This involves an addition of the TitleBlock.jsp,
>> modifying
>> Header.jsp to include it, and a change to jspwiki.css to hide it by
>> default.
>>
>> I think this would facilitate development of templates that use a
>> title
>> block area (which includes about 90% of mine). I can send in a
>> patch if
>> you're willing.
>>
>> Cheers,
>>
>> Murray
>>
>> .....................................................................
>> ......
>> Murray Altheim <murray07 at altheim.com>
>> === = =
>> http://www.altheim.com/murray/
>> = = ===
>> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk
>> = = = =
>>
>> Boundless wind and moon - the eye within eyes,
>> Inexhaustible heaven and earth - the light beyond light,
>> The willow dark, the flower bright - ten thousand houses,
>> Knock at any door - there's one who will respond.
>> -- The Blue Cliff Record
>>
Re: Vote: 2.6.0 release
Posted by Murray Altheim <mu...@altheim.com>.
Janne Jalkanen wrote:
>
> Yup, I like this approach better. It's very similar to what we are
> already doing with the footer and the MoreMenu. No need to confuse a
> developer with multiple approaches to the same basic problem.
>
> /Janne
Thanks -- I did note on finally getting around to doing an install
and testing that I accidentally left the one line out of Header.jsp
since I had been using my own template. That line is
<div id="header">
<wiki:Include page="TitleBlock.jsp" />
<div class="applicationlogo" >
...
(the new 'wiki:Include' line is line 12)
I'm guessing (as Dirk mentioned) that I needn't send in a patch for
this.
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: Vote: 2.6.0 release
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Yup, I like this approach better. It's very similar to what we are
already doing with the footer and the MoreMenu. No need to confuse a
developer with multiple approaches to the same basic problem.
/Janne
On 9 Nov 2007, at 08:59, Dirk Frederickx wrote:
> Murray,
>
> No need for a patch, it's only a one line extra in the Header.jsp ;-)
>
> Also, no need for display:none. When the TitleBox wikipage doesn't
> exist or is empty, nothing will be shown.
> Very simple, similar to the way copyrightNotice is handled.
>
>
> dirk
>
> On Nov 8, 2007 10:33 PM, Murray Altheim <mu...@altheim.com> wrote:
>> Dirk Frederickx wrote:
>>> Murray,
>>>
>>> Sound like a good idea. Similar to CopyrightNotice in the footer, we
>>> could add a title box in the header.
>>>
>>> I would prefer not to put any predefined format or contents in it
>>> (like suggested in your previous patch) but only show that content
>>> when the page exists.
>>> So, a new block could be added to the header:
>>>
>>> <div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
>>
>> That's fine, I'll make that change and submit a patch. We'll still
>> probably want to hide the TitleBlock.jsp by default in jspwiki.css.
>>
>>> Any votes for this ?
>>
>> Well, one from me. :-)
>>
>>
>> Murray
>>
>> .....................................................................
>> ......
>> Murray Altheim <murray07 at altheim.com>
>> === = =
>> http://www.altheim.com/murray/
>> = = ===
>> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk
>> = = = =
>>
>> Boundless wind and moon - the eye within eyes,
>> Inexhaustible heaven and earth - the light beyond light,
>> The willow dark, the flower bright - ten thousand houses,
>> Knock at any door - there's one who will respond.
>> -- The Blue Cliff Record
>>
Re: Vote: 2.6.0 release
Posted by Dirk Frederickx <di...@gmail.com>.
Murray,
No need for a patch, it's only a one line extra in the Header.jsp ;-)
Also, no need for display:none. When the TitleBox wikipage doesn't
exist or is empty, nothing will be shown.
Very simple, similar to the way copyrightNotice is handled.
dirk
On Nov 8, 2007 10:33 PM, Murray Altheim <mu...@altheim.com> wrote:
> Dirk Frederickx wrote:
> > Murray,
> >
> > Sound like a good idea. Similar to CopyrightNotice in the footer, we
> > could add a title box in the header.
> >
> > I would prefer not to put any predefined format or contents in it
> > (like suggested in your previous patch) but only show that content
> > when the page exists.
> > So, a new block could be added to the header:
> >
> > <div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
>
> That's fine, I'll make that change and submit a patch. We'll still
> probably want to hide the TitleBlock.jsp by default in jspwiki.css.
>
> > Any votes for this ?
>
> Well, one from me. :-)
>
>
> Murray
>
> ...........................................................................
> Murray Altheim <murray07 at altheim.com> === = =
> http://www.altheim.com/murray/ = = ===
> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
>
> Boundless wind and moon - the eye within eyes,
> Inexhaustible heaven and earth - the light beyond light,
> The willow dark, the flower bright - ten thousand houses,
> Knock at any door - there's one who will respond.
> -- The Blue Cliff Record
>
Re: Vote: 2.6.0 release
Posted by Murray Altheim <mu...@altheim.com>.
Dirk Frederickx wrote:
> Murray,
>
> Sound like a good idea. Similar to CopyrightNotice in the footer, we
> could add a title box in the header.
>
> I would prefer not to put any predefined format or contents in it
> (like suggested in your previous patch) but only show that content
> when the page exists.
> So, a new block could be added to the header:
>
> <div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
That's fine, I'll make that change and submit a patch. We'll still
probably want to hide the TitleBlock.jsp by default in jspwiki.css.
> Any votes for this ?
Well, one from me. :-)
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: Vote: 2.6.0 release
Posted by Dirk Frederickx <di...@gmail.com>.
Murray,
Sound like a good idea. Similar to CopyrightNotice in the footer, we
could add a title box in the header.
I would prefer not to put any predefined format or contents in it
(like suggested in your previous patch) but only show that content
when the page exists.
So, a new block could be added to the header:
<div class="titlebox"><wiki:InsertPage page="TitleBox"/></div>
Any votes for this ?
dirk
On Nov 8, 2007 2:24 AM, Murray Altheim <mu...@altheim.com> wrote:
> Janne,
>
> I know it's by no means a show stopper but I'd like to add the template
> feature I've sent in a patch for before, i.e., the optional use of a
> title block. This involves an addition of the TitleBlock.jsp, modifying
> Header.jsp to include it, and a change to jspwiki.css to hide it by
> default.
>
> I think this would facilitate development of templates that use a title
> block area (which includes about 90% of mine). I can send in a patch if
> you're willing.
>
> Cheers,
>
> Murray
>
> ...........................................................................
> Murray Altheim <murray07 at altheim.com> === = =
> http://www.altheim.com/murray/ = = ===
> SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
>
> Boundless wind and moon - the eye within eyes,
> Inexhaustible heaven and earth - the light beyond light,
> The willow dark, the flower bright - ten thousand houses,
> Knock at any door - there's one who will respond.
> -- The Blue Cliff Record
>
Re: Vote: 2.6.0 release
Posted by Murray Altheim <mu...@altheim.com>.
Janne,
I know it's by no means a show stopper but I'd like to add the template
feature I've sent in a patch for before, i.e., the optional use of a
title block. This involves an addition of the TitleBlock.jsp, modifying
Header.jsp to include it, and a change to jspwiki.css to hide it by
default.
I think this would facilitate development of templates that use a title
block area (which includes about 90% of mine). I can send in a patch if
you're willing.
Cheers,
Murray
...........................................................................
Murray Altheim <murray07 at altheim.com> === = =
http://www.altheim.com/murray/ = = ===
SGML Grease Monkey, Banjo Player, Wantanabe Zen Monk = = = =
Boundless wind and moon - the eye within eyes,
Inexhaustible heaven and earth - the light beyond light,
The willow dark, the flower bright - ten thousand houses,
Knock at any door - there's one who will respond.
-- The Blue Cliff Record
Re: Vote: 2.6.0 release
Posted by Janne Jalkanen <Ja...@ecyrd.com>.
Just went through the issues list, and it seems that we have two
things which are serious enough to warrant a fix:
https://issues.apache.org/jira/secure/IssueNavigator.jspa?
reset=true&mode=hide&sorter/order=DESC&sorter/
field=priority&resolution=-1&pid=12310732&fixfor=12312828
One is an IE bug, and one is a JavaMail configuration issue (which is
simply not working). These are currently assigned to Dirk and
Andrew, respectively. Then we need to document all the differences
between 2.4 and 2.6 to the documentation wiki... Any volunteers for
that?
/Janne
On 7 Nov 2007, at 11:36, Juan Pablo Santos Rodríguez wrote:
> Hi,
>
> I think it's fine for me too :-)
>
>
> regards,
> JP
>
>
> 2007/11/7, Dirk Frederickx <di...@gmail.com>:
>>
>> Ok for me.
>>
>> Wide images in IE6 is wrong, but not a showstopper I guess.
>>
>>
>>
>> dirk
>>
>> On 11/6/07, Janne Jalkanen <Ja...@ecyrd.com> wrote:
>>> Heya!
>>>
>>> I've been checking out the current CVS version (even bought
>>> Parallels
>>> and installed my zillion-year-old copy of Windows 98 on it to run
>>> IE ;-), and it seems to work pretty okay.
>>>
>>> Now, the question is, esteemed co-developers, can we finally release
>>> 2.6.0 and call it a stable? Are there any issues that still need
>>> fixing urgently before a release? Note that this means real
>>> showstoppers only; small things we can fix in 2.6.1...
>>>
>>> The reason why I would like to make a 2.6 release is that it
>>> would be
>>> the final LGPL-release and we could start then transferring the
>>> codebase to Apache... finally :-)
>>>
>>> /Janne
>>>
>>
Re: Vote: 2.6.0 release
Posted by Juan Pablo Santos Rodríguez <ju...@gmail.com>.
Hi,
I think it's fine for me too :-)
regards,
JP
2007/11/7, Dirk Frederickx <di...@gmail.com>:
>
> Ok for me.
>
> Wide images in IE6 is wrong, but not a showstopper I guess.
>
>
>
> dirk
>
> On 11/6/07, Janne Jalkanen <Ja...@ecyrd.com> wrote:
> > Heya!
> >
> > I've been checking out the current CVS version (even bought Parallels
> > and installed my zillion-year-old copy of Windows 98 on it to run
> > IE ;-), and it seems to work pretty okay.
> >
> > Now, the question is, esteemed co-developers, can we finally release
> > 2.6.0 and call it a stable? Are there any issues that still need
> > fixing urgently before a release? Note that this means real
> > showstoppers only; small things we can fix in 2.6.1...
> >
> > The reason why I would like to make a 2.6 release is that it would be
> > the final LGPL-release and we could start then transferring the
> > codebase to Apache... finally :-)
> >
> > /Janne
> >
>
Re: Vote: 2.6.0 release
Posted by Dirk Frederickx <di...@gmail.com>.
Ok for me.
Wide images in IE6 is wrong, but not a showstopper I guess.
dirk
On 11/6/07, Janne Jalkanen <Ja...@ecyrd.com> wrote:
> Heya!
>
> I've been checking out the current CVS version (even bought Parallels
> and installed my zillion-year-old copy of Windows 98 on it to run
> IE ;-), and it seems to work pretty okay.
>
> Now, the question is, esteemed co-developers, can we finally release
> 2.6.0 and call it a stable? Are there any issues that still need
> fixing urgently before a release? Note that this means real
> showstoppers only; small things we can fix in 2.6.1...
>
> The reason why I would like to make a 2.6 release is that it would be
> the final LGPL-release and we could start then transferring the
> codebase to Apache... finally :-)
>
> /Janne
>