You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/12/23 16:39:38 UTC
[GitHub] [solr] cpoerschke opened a new pull request #474: SOLR-15873: factor out a ReRankRescorer class
cpoerschke opened a new pull request #474:
URL: https://github.com/apache/solr/pull/474
_(Keeping this PR as "draft" whilst the "keep or not keep" discussion in SOLR-15873 is underway and also because this PR includes the #470 changes.)_
https://issues.apache.org/jira/browse/SOLR-15873
The Lucene `Rescorer.rescore` API signature takes three arguments: `rescore(IndexSearcher searcher, TopDocs firstPassTopDocs, int topN)`
The Solr `ReRankCollector` caps the number of documents that are passed to the `rescore` method so that `topN == firstPassTopDocs.scoreDocs.length` is always the case.
This pull request introduces a `ReRankRescorer` class for this specific use case i.e. a two arguments API signature variant `rescore(IndexSearcher searcher, TopDocs firstPassTopDocs)` with non-support of the three argument variant.
The motivation is to subsequently simplify the `LTR[Interleaving]Rescorer` logic by making use of the `topN == firstPassTopDocs.scoreDocs.length` condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke closed pull request #474: SOLR-15873: factor out a ReRankRescorer class
Posted by GitBox <gi...@apache.org>.
cpoerschke closed pull request #474:
URL: https://github.com/apache/solr/pull/474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on pull request #474: SOLR-15873: factor out a ReRankRescorer class
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #474:
URL: https://github.com/apache/solr/pull/474#issuecomment-1000814227
Closing for clarity since #478 combines #473 + #474 + #475 into one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org