You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "squah-confluent (via GitHub)" <gi...@apache.org> on 2026/03/10 12:20:52 UTC
[PR] KAFKA-20269: Refactor assignment update for delayed share assignments [kafka]
squah-confluent opened a new pull request, #21695:
URL: https://github.com/apache/kafka/pull/21695
Refactor the share target assignment update method to return both the
target assignment epoch and target assignment. When assignment batching
or assignment offload are implemented, the target assignment update
method may return the last target assignment, depending on timings and
the group coordinator config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20269 [2/N]: Refactor assignment update for delayed share assignments [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #21695:
URL: https://github.com/apache/kafka/pull/21695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20269 [2/N]: Refactor assignment update for delayed share assignments [kafka]
Posted by "squah-confluent (via GitHub)" <gi...@apache.org>.
squah-confluent commented on code in PR #21695:
URL: https://github.com/apache/kafka/pull/21695#discussion_r2912605902
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -289,6 +289,16 @@ private static UpdateTargetAssignmentResult<Assignment> fromLastTargetAssignment
group.targetAssignment(member.memberId(), member.instanceId())
);
}
+
+ private static UpdateTargetAssignmentResult<Assignment> fromLastTargetAssignment(
+ ShareGroup group,
+ ShareGroupMember member
Review Comment:
I don't think we can do this since `ModernGroup` doesn't have `targetAssignment(memberId, instanceId)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20269 [2/N]: Refactor assignment update for delayed share assignments [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #21695:
URL: https://github.com/apache/kafka/pull/21695#discussion_r2912591518
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -289,6 +289,16 @@ private static UpdateTargetAssignmentResult<Assignment> fromLastTargetAssignment
group.targetAssignment(member.memberId(), member.instanceId())
);
}
+
+ private static UpdateTargetAssignmentResult<Assignment> fromLastTargetAssignment(
+ ShareGroup group,
+ ShareGroupMember member
Review Comment:
I wonder whether we could generalize the existing one and use `ModernGroup` and `ModernGroupMember`. Have you tried it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20269 [2/N]: Refactor assignment update for delayed share assignments [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #21695:
URL: https://github.com/apache/kafka/pull/21695#discussion_r2912620688
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -289,6 +289,16 @@ private static UpdateTargetAssignmentResult<Assignment> fromLastTargetAssignment
group.targetAssignment(member.memberId(), member.instanceId())
);
}
+
+ private static UpdateTargetAssignmentResult<Assignment> fromLastTargetAssignment(
+ ShareGroup group,
+ ShareGroupMember member
Review Comment:
Ah, missed it. Thanks for clarifying.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org