You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/12 15:12:41 UTC

[GitHub] [airflow] saimon46 opened a new issue #17582: DAG trigger with config params visualisation with proper deserialisation

saimon46 opened a new issue #17582:
URL: https://github.com/apache/airflow/issues/17582


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   **Description**
   
   Add a proper `params` configuration in the trigger page of a DAG showing the dict without the serialisation format `__var` and `__type` but with a flat, normal dict.
   
   **Use case / motivation**
   
   Now we are using the `params` dictionary that can be configured in the DAG. In our case this configuration is a dictionary with nested fields. When this is showed in the trigger page is we see the serialised format of the dictionary with the content of the dict in `__var` and `__type = dict`. In that form instead we should have the dictionary in a flat format with only the different contents nested. In the images you can see some examples.
   
   To improve this we can deserialise the dict before being visualised in the UI.
   <!-- What do you want to happen?
   
   Rather than telling us how you might implement this solution, try to take a
   step back and describe what you are trying to achieve.
   
   -->
   
   **Related Issues**
   
   Not that I know. I've tried to search for it but nobody said anything about it.
   <!-- Is there currently another issue associated with this? -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-900949587


   > Those `__type` and `__val` keys are added by Airflow’s DAG serialisation logic, and the UI shouldn’t see them in the first place. I’m suspecting this is a bug in (de)serialisation, and if that’s correct this would be very deep down in the stack (in other words may not be as easy to fix as it appears to).
   
   Yep. we neee some black-woodo magic of one of our serialization wizards ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr closed issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
uranusjr closed issue #17582:
URL: https://github.com/apache/airflow/issues/17582


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-900825011


   Those `__type` and `__val` keys are added by Airflow’s DAG serialisation logic, and the UI shouldn’t see them in the first place. I’m suspecting this is a bug in (de)serialisation, and if that’s correct this would be very deep down in the stack.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] VLADPOLUNIN commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
VLADPOLUNIN commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-898069899


   Спасибо 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] VLADPOLUNIN commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
VLADPOLUNIN commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-900715611


   👋😊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr edited a comment on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-900825011






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] saimon46 commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
saimon46 commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-900295071


   The version we are using is the latest 2.1.2. Unfortunately I don't have a lot of knowledge of the Airflow UI, about standards and best practise and I don't even know where is the best place where we can apply the fix. On the UI or backend? If you guide me on it I can put an effort and create a PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-900825011


   Those `__type` and `__val` keys are added by Airflow’s DAG serialisation logic, and the UI shouldn’t see them in the first place. I’m suspecting this is a bug in (de)serialisation, and if that’s correct this would be very deep down in the stack.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-920790119


   I believe #17100 actually fixed this, although not sure if it’s intentional or accidental. That PR should be a part of 2.2 (including the currently available beta), so I’ll close this for now; feel free to reopen if this is still an issue in 2.2.
   
   This is how the Trigger DAG view renders for me in `main`:
   
   ![image](https://user-images.githubusercontent.com/605277/133598810-f766edf5-e87a-48c3-a328-7647a029c4f3.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-900949587


   > Those `__type` and `__val` keys are added by Airflow’s DAG serialisation logic, and the UI shouldn’t see them in the first place. I’m suspecting this is a bug in (de)serialisation, and if that’s correct this would be very deep down in the stack (in other words may not be as easy to fix as it appears to).
   
   Yep. we neee some black-woodo magic of one of our serialization wizards ;)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-899105694


   Ah. yeah. I confirmed it's the case in main as well. Would you be willing to provide a PR fixing it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-899104748


   Which version of Airlfow? Sounds like quite improbable that others have not seen it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] VLADPOLUNIN commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
VLADPOLUNIN commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-900715611


   👋😊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-897722963


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] VLADPOLUNIN commented on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
VLADPOLUNIN commented on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-898070411


   > Thanks for opening your first issue here! Be sure to follow the issue template!
   > 
   Hi 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr edited a comment on issue #17582: DAG trigger with config params visualisation with proper deserialisation

Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on issue #17582:
URL: https://github.com/apache/airflow/issues/17582#issuecomment-900825011






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org