You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yx9o (via GitHub)" <gi...@apache.org> on 2025/09/28 14:35:23 UTC
[PR] [ISSUE #9741] Optimize authentication whitelist lookup efficiency [rocketmq]
yx9o opened a new pull request, #9742:
URL: https://github.com/apache/rocketmq/pull/9742
Fixes #9741 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9741] Optimize authentication whitelist lookup efficiency [rocketmq]
Posted by "majialoong (via GitHub)" <gi...@apache.org>.
majialoong commented on PR #9742:
URL: https://github.com/apache/rocketmq/pull/9742#issuecomment-3404605651
Thanks for the PR, it looks like the same issue exists in `AbstractAuthorizationStrategy`. I'll file a patch to improve it.
https://github.com/apache/rocketmq/blob/3dd4bfd4f86f7235b7054798a718bb3666862369/auth/src/main/java/org/apache/rocketmq/auth/authorization/strategy/AbstractAuthorizationStrategy.java#L33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9741] Optimize authentication whitelist lookup efficiency [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #9742:
URL: https://github.com/apache/rocketmq/pull/9742#issuecomment-3390539567
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/9742?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 48.24%. Comparing base ([`b1a7ac8`](https://app.codecov.io/gh/apache/rocketmq/commit/b1a7ac80ddb5409bdb58dbcec6a894bb837db009?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3e4001b`](https://app.codecov.io/gh/apache/rocketmq/commit/3e4001ba6967c7be111e4146177ad4a6cbde4cad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #9742 +/- ##
=============================================
- Coverage 48.36% 48.24% -0.12%
+ Complexity 12202 12170 -32
=============================================
Files 1313 1313
Lines 93340 93340
Branches 11962 11962
=============================================
- Hits 45140 45029 -111
- Misses 42629 42726 +97
- Partials 5571 5585 +14
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/9742?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9741] Optimize authentication whitelist lookup efficiency [rocketmq]
Posted by "yx9o (via GitHub)" <gi...@apache.org>.
yx9o commented on code in PR #9742:
URL: https://github.com/apache/rocketmq/pull/9742#discussion_r2420437009
##########
auth/src/main/java/org/apache/rocketmq/auth/authentication/strategy/AbstractAuthenticationStrategy.java:
##########
@@ -30,7 +30,7 @@
public abstract class AbstractAuthenticationStrategy implements AuthenticationStrategy {
protected final AuthConfig authConfig;
- protected final List<String> authenticationWhitelist = new ArrayList<>();
+ protected final Set<String> authenticationWhitelist = new HashSet<>();
Review Comment:
Completed, please review again, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9741] Optimize authentication whitelist lookup efficiency [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on code in PR #9742:
URL: https://github.com/apache/rocketmq/pull/9742#discussion_r2418344467
##########
auth/src/main/java/org/apache/rocketmq/auth/authentication/strategy/AbstractAuthenticationStrategy.java:
##########
@@ -30,7 +30,7 @@
public abstract class AbstractAuthenticationStrategy implements AuthenticationStrategy {
protected final AuthConfig authConfig;
- protected final List<String> authenticationWhitelist = new ArrayList<>();
+ protected final Set<String> authenticationWhitelist = new HashSet<>();
Review Comment:
suggest rename it to authenticationWhiteSet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9741] Optimize authentication whitelist lookup efficiency [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #9742:
URL: https://github.com/apache/rocketmq/pull/9742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org