You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/07/10 19:40:15 UTC
[GitHub] [buildstream] juergbi opened a new pull request, #1679: setup.py, setup.cfg: Disable gRPC fork support
juergbi opened a new pull request, #1679:
URL: https://github.com/apache/buildstream/pull/1679
gRPC fork support is not compatible with the default polling engine of
certain gRPC versions on modern Linux systems (epollex) and it also does
not work if another thread is calling into gRPC. It also causes Python
to segfault in the test suite in some environments.
As BuildStream, after gRPC initialization, uses `fork()` only to
`exec()` subprocesses, the gRPC fork support (`atfork` handler) is not
needed. Setting `GRPC_ENABLE_FORK_SUPPORT=0` disables gRPC fork support,
fixing Python segmentation faults and error messages caused by the
`atfork` handler.
https://github.com/grpc/grpc/issues/29044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] gtristan commented on pull request #1679: setup.py, setup.cfg: Disable gRPC fork support
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #1679:
URL: https://github.com/apache/buildstream/pull/1679#issuecomment-1181415361
Ohhh this is super neat, I was actually looking for a way to generate the entrypoint while setting env vars but came up short, and didn't notice the hack we had in place, so this does just that.
An extension to the leading comment (which currently states that this hack is only about load time performance) might be nice, but I'm fine with it either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] juergbi merged pull request #1679: setup.py, setup.cfg: Disable gRPC fork support
Posted by GitBox <gi...@apache.org>.
juergbi merged PR #1679:
URL: https://github.com/apache/buildstream/pull/1679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org