You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2012/08/21 03:23:37 UTC

Review Request: Pick newer system VM template for vmware in latest cloudstack release.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6702/
-----------------------------------------------------------

Review request for cloudstack and Kishan Kavala.


Description
-------

Modifying reference to system VM template for vmware for the 2.2.14 to 3.0 upgrade path so that it picks up the burbank template if upgrading from 2.2.14 to 3.0.5 or beyond, and the acton template if upgrading from 2.2.14 to 3.0.[0-4].


This addresses bug CS-16075.


Diffs
-----

  server/src/com/cloud/maint/Version.java 184b9a6 
  server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 43e2c00 

Diff: https://reviews.apache.org/r/6702/diff/


Testing
-------


Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Pick newer system VM template for vmware in latest cloudstack release.

Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6702/#review10726
-----------------------------------------------------------



server/src/com/cloud/upgrade/dao/Upgrade2214to30.java
<https://reviews.apache.org/r/6702/#comment23144>

    to get current version, query should be 
    select version from version order by id desc limit 1;



server/src/com/cloud/upgrade/dao/Upgrade2214to30.java
<https://reviews.apache.org/r/6702/#comment23145>

    Vmware template upgrade code should go into Upgrade302to40.
    In Upgrade2214to30 for Vmware case, template upgrade can be removed completely. Older versions (< 302) won't have this code anyway. No need to selectively pick template.


- Kishan Kavala


On Aug. 21, 2012, 1:23 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6702/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2012, 1:23 a.m.)
> 
> 
> Review request for cloudstack and Kishan Kavala.
> 
> 
> Description
> -------
> 
> Modifying reference to system VM template for vmware for the 2.2.14 to 3.0 upgrade path so that it picks up the burbank template if upgrading from 2.2.14 to 3.0.5 or beyond, and the acton template if upgrading from 2.2.14 to 3.0.[0-4].
> 
> 
> This addresses bug CS-16075.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/maint/Version.java 184b9a6 
>   server/src/com/cloud/upgrade/dao/Upgrade2214to30.java 43e2c00 
> 
> Diff: https://reviews.apache.org/r/6702/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>